QFile::copy copies only 3kb

[wysota]

There is no magic wand here. Don't expect a single call to exist that does all the work for you. You need to design an algorithm that will fulfill all your requirements. You know what the problem is so you need to find a way to resolve it. You need an approach that will 1) detect new files in the directory and the time they appeared there, 2) detect when a new file is completely copied into the directory, 3) copy the file to its proper place. Once you do that you need to implement the algorithm in code. And don't expect the solution to be a single linear block of code. It's likely you'll have to implement a class that does that using signals and slots.

[camol]

I've tried sth like this:

void DServer::newFiles_()
{
    this->inputWatcher->blockSignals(true);
    fileTimer->start();
}
 
void DServer::newFilesTimer_()
{
    output = "";
    ps.start("du -sk /home/camol/INPUT_DICOM");
}
 
void DServer::cmdExec_data_available()
{
    output += ps.readAllStandardOutput() + "\n";
}
 
void DServer::cmdExec_finish(int pl)
{
    QTextStream(stdout) << "INPUT FOLDER SIZE: " << output.remove("/home/camol/INPUT_DICOM")<<endl;
    ps.close();
    QTextStream(stdout) << "INPUT FOLDER SIZE int: " << output.toInt()<<endl;
    if(output.toInt() > lastInput)
        this->lastInput = output.toInt();
    else
    {
        QTextStream(stdout) << "mam wszystko: " << lastInput<<endl;
        inputFiles = getPaths(QDir::homePath() + "/INPUT_DICOM");
        this->fileTimer->stop();
        emit this->_copy();
    }
}

void DServer::newFiles_()
{
    this->inputWatcher->blockSignals(true);
    fileTimer->start();
}

void DServer::newFilesTimer_()
{
    output = "";
    ps.start("du -sk /home/camol/INPUT_DICOM");
}

void DServer::cmdExec_data_available()
{
    output += ps.readAllStandardOutput() + "\n";
}

void DServer::cmdExec_finish(int pl)
{
    QTextStream(stdout) << "INPUT FOLDER SIZE: " << output.remove("/home/camol/INPUT_DICOM")<<endl;
    ps.close();
    QTextStream(stdout) << "INPUT FOLDER SIZE int: " << output.toInt()<<endl;
    if(output.toInt() > lastInput)
        this->lastInput = output.toInt();
    else
    {
        QTextStream(stdout) << "mam wszystko: " << lastInput<<endl;
        inputFiles = getPaths(QDir::homePath() + "/INPUT_DICOM");
        this->fileTimer->stop();
        emit this->_copy();
    }
}

To copy to clipboard, switch view to plain text mode 

ps is a QProcess object and it works it constantly updates the size of the folder during copying the files but still copying the files doesn't work

[camol]

Now I am completely out of ideas, I've just splitted the code and made the archiving-copy side, which was presented, as a separate application which I am running when all files are ready to be copied. However it still doesn't work and I don't know why

[wysota]

Are you able to sucessfully and properly detect when the file is ready to be copied? How do you do that? Because blocking signals from the file watcher is probably not going to give you the result you expect.

[camol]

Now I'm not blocking anything, I made a separate program and I run it when copied all files. Basically I tried the manual approach to the problem but I still get the same result, firstly I thought that was the problem of QFileSytemWatcher signal etc. but it didn't get the right result.

[wysota]

So the following also copies 3kB of the file? Try it for different files in different directories.

int main(int argc, char **argv){
  QFIle::copy(argv[1], "/tmp/testfile");
  return 0;
}

int main(int argc, char **argv){
  QFIle::copy(argv[1], "/tmp/testfile");
  return 0;
}

To copy to clipboard, switch view to plain text mode 

[camol]

You've enlighten but but sth to test and before I do those copies I am doing my method for doing the anonimization of the files when comment it the files are copied well, I moved it and try to anonimize the copied files but it also "corupts" the files :/ The function looks like this:

void ArchiveDicom::anonymous(QString path, QString file)
{
    DcmFileFormat fileformat;
    OFCondition status = fileformat.loadFile(file.toStdString().c_str());
 
    if (status.good())
    {
        OFString patientName;
        if (fileformat.getDataset()->findAndGetOFString(DCM_PatientName, patientName).good())
        {
            QString currentPatientName(patientName.c_str());
 
            if(currentPatientName == lastPatientName)
            {
                writeToAnonym(lastGenNum, path, fileformat, currentPatientName, file);
            }
            else
            {
                std::string randNum = generateNumber();
                writeToAnonym(randNum, path, fileformat, currentPatientName, file);
                lastPatientName = currentPatientName;
                lastGenNum = randNum;
            }
        }
        else
            std::cerr << "Error: cannot access Patient's Name!" << endl;
     }
     else
         std::cerr << "Error: cannot read DICOM file (" << status.text() << ")" << endl;
 }

void ArchiveDicom::anonymous(QString path, QString file)
{
    DcmFileFormat fileformat;
    OFCondition status = fileformat.loadFile(file.toStdString().c_str());

    if (status.good())
    {
        OFString patientName;
        if (fileformat.getDataset()->findAndGetOFString(DCM_PatientName, patientName).good())
        {
            QString currentPatientName(patientName.c_str());

            if(currentPatientName == lastPatientName)
            {
                writeToAnonym(lastGenNum, path, fileformat, currentPatientName, file);
            }
            else
            {
                std::string randNum = generateNumber();
                writeToAnonym(randNum, path, fileformat, currentPatientName, file);
                lastPatientName = currentPatientName;
                lastGenNum = randNum;
            }
        }
        else
            std::cerr << "Error: cannot access Patient's Name!" << endl;
     }
     else
         std::cerr << "Error: cannot read DICOM file (" << status.text() << ")" << endl;
 }

To copy to clipboard, switch view to plain text mode 

Basically the function changes the TAG, in the .dcm file, which consists Patient Name and replaces it with some random numbers then stores the patient name which was readed.

[wysota]

So does my example work or not?

[camol]

I found that my method works well in copying but there is sth wrong with the function I wrote above.

[wysota]

Without knowing what your functions do it's not possible to provide any assistance.

[camol]

You've enlighten but but sth to test and before I do those copies I am doing my method for doing the anonimization of the files when comment it the files are copied well, I moved it and try to anonimize the copied files but it also "corupts" the files :/ The function looks like this:

void ArchiveDicom::anonymous(QString path, QString file)
{
    DcmFileFormat fileformat;
    OFCondition status = fileformat.loadFile(file.toStdString().c_str());
 
    if (status.good())
    {
        OFString patientName;
        if (fileformat.getDataset()->findAndGetOFString(DCM_PatientName, patientName).good())
        {
            QString currentPatientName(patientName.c_str());
 
            if(currentPatientName == lastPatientName)
            {
                writeToAnonym(lastGenNum, path, fileformat, currentPatientName, file);
            }
            else
            {
                std::string randNum = generateNumber();
                writeToAnonym(randNum, path, fileformat, currentPatientName, file);
                lastPatientName = currentPatientName;
                lastGenNum = randNum;
            }
        }
        else
            std::cerr << "Error: cannot access Patient's Name!" << endl;
     }
     else
         std::cerr << "Error: cannot read DICOM file (" << status.text() << ")" << endl;
 }

void ArchiveDicom::anonymous(QString path, QString file)
{
    DcmFileFormat fileformat;
    OFCondition status = fileformat.loadFile(file.toStdString().c_str());

    if (status.good())
    {
        OFString patientName;
        if (fileformat.getDataset()->findAndGetOFString(DCM_PatientName, patientName).good())
        {
            QString currentPatientName(patientName.c_str());

            if(currentPatientName == lastPatientName)
            {
                writeToAnonym(lastGenNum, path, fileformat, currentPatientName, file);
            }
            else
            {
                std::string randNum = generateNumber();
                writeToAnonym(randNum, path, fileformat, currentPatientName, file);
                lastPatientName = currentPatientName;
                lastGenNum = randNum;
            }
        }
        else
            std::cerr << "Error: cannot access Patient's Name!" << endl;
     }
     else
         std::cerr << "Error: cannot read DICOM file (" << status.text() << ")" << endl;
 }

To copy to clipboard, switch view to plain text mode 

Basically the function changes the TAG, in the .dcm file, which consists Patient Name and replaces it with some random numbers then stores the patient name which was readed.

I wrote this above what it does and I can't figure out why it is wrong

[wysota]

Well, I don't know what generateNumber(), writeToAnonym, DcmFileFormat, OFCondition and OFString do.

[camol]

Three last items are members of DCMTK library for DICOM files. GenerateNumber-generates simply a random number which is placed instead of patient name in the TAG .dcm file, and writeToAnonym writes the path of the file and what was in the TAG in .dcm file to the txt file.

[wysota]

And at which point your code starts malfunctioning?

[camol]

What you exactly mean? I am just manually putting files in folders to my INPUT folder and the just run from console my from which does the anonimization and copies the files to another directory and I see that is sth wrong with that function in writeToAnonym:

void ArchiveDicom::writeToAnonym(std::string num, QString path, DcmFileFormat fileformat, QString currentPatientName, QString file)
{
    if (anonymFile->open(QIODevice::ReadWrite | QIODevice::Append) == true)
    {
        QTextStream out(anonymFile);
        out << path << " " << currentPatientName << endl;
        anonymFile->close();
        fileformat.getDataset()->putAndInsertString(DCM_PatientName, num.c_str());
        fileformat.saveFile(file.toStdString().c_str());
    }
    else
    {
        QTextStream(stdout)<<"couldn't open anonym.an file, so I didn't anonymize the file"<<endl;
    }
}

void ArchiveDicom::writeToAnonym(std::string num, QString path, DcmFileFormat fileformat, QString currentPatientName, QString file)
{
    if (anonymFile->open(QIODevice::ReadWrite | QIODevice::Append) == true)
    {
        QTextStream out(anonymFile);
        out << path << " " << currentPatientName << endl;
        anonymFile->close();
        fileformat.getDataset()->putAndInsertString(DCM_PatientName, num.c_str());
        fileformat.saveFile(file.toStdString().c_str());
    }
    else
    {
        QTextStream(stdout)<<"couldn't open anonym.an file, so I didn't anonymize the file"<<endl;
    }
}

To copy to clipboard, switch view to plain text mode 

this line is stinky fileformat.saveFile(file.toStdString().c_str()); I got this from the site from the example from DCMTK usage, when I comment this everything works so, fortunetelly coping is ok but without this line the changes described above won't take place.

[wysota]

What you exactly mean?

I mean your code is not a black box. You can do more than just feed it with data and see if the result is correct. I assume you have some algorithm that the code should implement and at different stages of the algorithm the code produces some intermediate results. So I'm asking at which point those results start differing from what should be happening according to your algorithm.

[camol]

I see. I try simply anonymize the files. After opening->reading PatientName tag everything is ok, but the I write to the file in the place of PatientName then I have to save the file and I get the file corrupted.


I think I got I will report my result in short time