Need an advise about adding objects to vector-

I have a classA, it creates objectsB * (by pointer)

Code:

---

my_objectB = new ObjectB; ( inside classA)

---

And from the main, I want to add "objectsB" to a vector.

Code:

---

vector<objectC*> my_vector; (my vector is private for main )

---

So, I can write inside main_create():

Code:

---

for (int x=0;x<10;xx++)
 {
   ClassA class_a* = new ClassA;  
   my_vector.push_back(class_a->my_objectB)
}

---

My doubt is ... Every time I create class_a, a new instance is created, and there is no re-write of class_a->my_objectB, ins't it ?

Ok. on main I have main_process, a function that are going to do thing with the vector. My question is , objectB instances inside the vector exist ? or maybe I have a risk of crash becasue thet were created by a temporal classA inside 'main_create'.

By last. I have to free every objectB instance inside the vector with pop_back ? Or need I to do more ?
Any tip ? Thanks.

Quote:

---

And from the main, I want to add "objectsB" to a vector.

---

This all sounds very confused.

Quote:

---

And from the main, I want to add "objectsB" to a vector.

---

Let me see if I understand:
You have a vector in main.
And you want to add a member of ClassA (objectB) to that vector - is that correct?
If this is correct, then you are doing something very wrong!

Quote:

---

Originally Posted by tonnot

Every time I create class_a, a new instance is created, and there is no re-write of class_a->my_objectB, ins't it ?

---

No, as long my_objectB is not a static member of the class.

Quote:

---

objectB instances inside the vector exist ?

---

If they were created on the heap (using operator new), they will exist until you call "delete" on them.

Quote:

---

I have to free every objectB instance inside the vector with pop_back ? Or need I to do more ?

---

You need to call "delete" on the object to "free" it, pop_back will just remove the pointer from vector, it will not release the associated memory.

Quote:

---

Any tip ?

---

I think you should do some redesign. For example, I have a feeling that at some point you want to delete each object from the vector. This is confusing, because if they all are a members of some ClassA, then it's more "natural" to think that the ClassA instance "owns" instance of ClassB, so it should be responsible for deleting them. If you explicitly delete instance from vector, then you will have a "dangling" pointer in ClassA objects.
Maybe you should use some kind of factory method for creating objects of ClassB instead of storing pointers to members. Or store pointers to ClassA in your vector and make this class responsible for ClassB objects.
Btw if the code snippet (the for loop) is unchanged in your actual code, then probably you have a memory leak - you do not "delete" the ClassA objects.

Thanks.

Ok. the post are a initial skeleton.
My main doubts are related with the inner objects.

Code:

---

for (int x=0;x<10;xx++)
    {
    ClassA class_a* = new ClassA;
    my_vector.push_back(class_a->my_objectB)
    }

---

For every x I create a 'volatil' A ???
class_a is automatically deleted at the end of the loop???
Thanks

No, nothing is deleted. I suggest you spend some time reading "Thinking in C++", it deals with problems such as your current one (ownership and stuff).