Rename File

This is simple program, but is not doing the expected...
(Part of the code)

Code:

---

QString ms, fileName;
    QDir dr;
    int dbg;
    QFileInfoList filesList;
    QString ds, qs;
    uint nf;
    int numFiles = filesList.count();
    QUuid uRand = QUuid::createUuid ();
    QUuid uRand2 = QUuid::createUuid ();
 
    for (int ii = 0; ii < numFiles; ii++) {
        fileName = filesList.at(ii).fileName();
        if (dr.rename(fileName, qs.sprintf("%07u", uRand.data1++)))
            out << "Success-I, ii: " << ii << ", fileName: " << fileName << ", uRand.data1: " << uRand.data1 << endl;
        else out << "Fail-I" << endl;
    }
    for (int ii = 0; ii < numFiles; ii++) {
        fileName = filesList.at(ii).fileName();
        if (dr.rename(fileName, qs.sprintf("%07u", uRand2.data1++)))
            out << "Success-II, ii: " << ii << ", fileName: " << fileName << ", uRand.data1: " << uRand2.data1 << endl;
        else out << "Fail-II" << endl;
    }

---

Output always is:
Success-I, ii: 0, fileName: 915190944, uRand.data1: 815395111
Success-I, ii: 1, fileName: 915190945, uRand.data1: 815395112
Success-I, ii: 2, fileName: 915190946, uRand.data1: 815395113
Success-I, ii: 3, fileName: 915190947, uRand.data1: 815395114
Success-I, ii: 4, fileName: 915190948, uRand.data1: 815395115
Success-I, ii: 5, fileName: 915190949, uRand.data1: 815395116
Success-I, ii: 6, fileName: 915190950, uRand.data1: 815395117
Success-I, ii: 7, fileName: 915190951, uRand.data1: 815395118
Success-I, ii: 8, fileName: 915190952, uRand.data1: 815395119
Success-I, ii: 9, fileName: 915190953, uRand.data1: 815395120
Success-I, ii: 10, fileName: 915190954, uRand.data1: 815395121
Success-I, ii: 11, fileName: 915190955, uRand.data1: 815395122
Fail-II
Fail-II
Fail-II
Fail-II
Fail-II
Fail-II
Fail-II
Fail-II
Fail-II
Fail-II
Fail-II
Fail-II

Why is it not able to rename file second time?

Pls see for yourself, and suggest ways to make it work.

Thanks.

because you just renamed them all!

Not that I understand how there is anything in QFileInfoList variable since it is only default initialised.

There is a way around. Use QDir::setPath() and QFileInfoList::entryInfoList(), first for some folder & then for the required folder. And voila.

Code:

---

int rnmDirFiles (QString ms, QDir dr, int dbg, QFileInfoList filesList, QString ds, uint nf) {
    int numFiles;
    QUuid uRand = QUuid::createUuid ();
    QUuid uRand2 = QUuid::createUuid ();
    QString fileName = "";
    numFiles = filesList.count();
 
    QString absPath = dr.absolutePath(); // store current path
    for (int ii = 0; ii < numFiles; ii++) {
        fileName = filesList.at(ii).fileName();
        if (dr.rename(fileName, qs.sprintf("%07u", uRand.data1++)))
            out << "Success-I, ii: " << ii << ", fileName: " << fileName << ", uRand.data1: " << uRand.data1 << endl;
        else out << "Fail-I" << endl;
    }
 
   //change path temporarily, else renaming in succession not possible
    dr.setPath("/tmp");
    filesList = dr.entryInfoList(QDir::Files, QDir::Name);
 
    // this second QDir::setPath and QFileInfoList::entryInfoList is reqd., otherwise second time rename fails
    dr.setPath(absPath);
    filesList = dr.entryInfoList(QDir::Files, QDir::Name);
 
    for (int ii = 0; ii < numFiles; ii++) {
        fileName = filesList.at(ii).fileName();
        if (dr.rename(fileName, qs.sprintf("%07u", uRand2.data1++)))
            out << "Success-II, ii: " << ii << ", fileName: " << fileName << ", uRand.data1: " << uRand2.data1 << endl;
        else out << "Fail-II" << endl;
    }
    return 1;
}

---

file renaming is successful both times now.

Output always is:
Success-I, ii: 0, fileName: 915190944, uRand.data1: 815395111
Success-I, ii: 1, fileName: 915190945, uRand.data1: 815395112
Success-I, ii: 2, fileName: 915190946, uRand.data1: 815395113
Success-I, ii: 3, fileName: 915190947, uRand.data1: 815395114
Success-I, ii: 4, fileName: 915190948, uRand.data1: 815395115
Success-I, ii: 5, fileName: 915190949, uRand.data1: 815395116
Success-I, ii: 6, fileName: 915190950, uRand.data1: 815395117
Success-I, ii: 7, fileName: 915190951, uRand.data1: 815395118
Success-I, ii: 8, fileName: 915190952, uRand.data1: 815395119
Success-I, ii: 9, fileName: 915190953, uRand.data1: 815395120
Success-I, ii: 10, fileName: 915190954, uRand.data1: 815395121
Success-I, ii: 11, fileName: 915190955, uRand.data1: 815395122

Success-II, ii: 0, fileName: 915190944, uRand.data1: 815395111
Success-II, ii: 1, fileName: 915190945, uRand.data1: 815395112
Success-II, ii: 2, fileName: 915190946, uRand.data1: 815395113
Success-II, ii: 3, fileName: 915190947, uRand.data1: 815395114
Success-II, ii: 4, fileName: 915190948, uRand.data1: 815395115
Success-II, ii: 5, fileName: 915190949, uRand.data1: 815395116
Success-II, ii: 6, fileName: 915190950, uRand.data1: 815395117
Success-II, ii: 7, fileName: 915190951, uRand.data1: 815395118
Success-II, ii: 8, fileName: 915190952, uRand.data1: 815395119
Success-II, ii: 9, fileName: 915190953, uRand.data1: 815395120
Success-II, ii: 10, fileName: 915190954, uRand.data1: 815395121
Success-II, ii: 11, fileName: 915190955, uRand.data1: 815395122

I don't know how you can be certain of that, since you're using the same names both times. Rather than trust the rename() function to return a value you expect, I'd give them different names on each pass to ensure that the operation is really doing what you want, at least as a test.