How to stop multiple appearance of a widget

[Sarma]

hi all,
I have an application in which when I press a button I should get a find dialog box. Thing is if I press the button again, I shouldnot get one more dialog box. The previous one should appear.
My present code is like this:

CPT::CPT(QWidget *parent):QWidget(parent)
 {
    //some other lines of code
    QPushButton *but=new QPushButton(this);
    QObject::connect(but,SIGNAL(clicked()),this,SLOT(findbox()));
   //remaining program
 }
 void CPT::findbox()
 {
    QWidget  *findstr=new QWidget;
    //other widgets added to it
    findstr->show();
 }

CPT::CPT(QWidget *parent):QWidget(parent)
 {
    //some other lines of code
    QPushButton *but=new QPushButton(this);
    QObject::connect(but,SIGNAL(clicked()),this,SLOT(findbox()));
   //remaining program
 }
 void CPT::findbox()
 {
    QWidget  *findstr=new QWidget;
    //other widgets added to it
    findstr->show();
 }

To copy to clipboard, switch view to plain text mode 

So kindly help me in this problem.

[sunil.thaha]

Window::showFindDialog(){
    static FindDialog* pFindDlg = 0;
    if( pFindDlg == 0 ) {
        pFindDlg = new FindDialog( this, "") ;
     }
   pFindDlg->show();
   pFindDlg->raise();
   pFindDlg->setActiveWindow();
 
}

Window::showFindDialog(){
    static FindDialog* pFindDlg = 0;
    if( pFindDlg == 0 ) {
        pFindDlg = new FindDialog( this, "") ;
     }
   pFindDlg->show();
   pFindDlg->raise();
   pFindDlg->setActiveWindow();

}

To copy to clipboard, switch view to plain text mode 

[Sarma]

hi sunil,
can you please show me the changes that I have to make in my program. And u have written FindDialog in your code. Is there any such default dialog box provided by Qt.

regards,
Sarma.

[sunil.thaha]

I just called the Dialog you wanted to show as FindDialog That is all !

[Sarma]

sorry sunil,
That is giving good number of errors. It says that the second line (of your code) is wrong and because of this, it says that pFindDlg is not defined. can you suggest me other method

[sunil.thaha]

Try the Attachment

[Sarma]

hi sunil,
well, thanks for your help. But no where I have found the code that you have written previously. In which file should I see that . And can you please tell me how to generate the .ui files and use them in our ordinary program.

Thanks & regards,
Sarma.

[wysota]

See the FAQ.

[Sarma]

sir,
Iam getting errors as I said previously . Kindly show me the changes that I have to make in my code(I have send it in my first post).

Thanks & regards,
Sarma.

[wysota]

Look at the FAQ entry I mentioned. The code is there -- literally. Especially note the "static" keyword.

[Sarma]

sir,
I have modified my code like this:

CPT::CPT(QWidget *parent):QWidget(parent)
      {
         //some other lines of code
         QPushButton *but=new QPushButton(this);
         QObject::connect(but,SIGNAL(clicked()),this,SLOT(findbox()));
         //remaining program
       }
      void CPT::findbox()
       {
          QWidget  *fwin=new QWidget;
           //other widgets added to it
           //fwin->show();
           static fwin *form2 = new fwin(this);
           form2->show();
           form2->activateWindow(); // or form2->setActiveWindow() in Qt3
           form2->raise();
        }

CPT::CPT(QWidget *parent):QWidget(parent)
      {
         //some other lines of code
         QPushButton *but=new QPushButton(this);
         QObject::connect(but,SIGNAL(clicked()),this,SLOT(findbox()));
         //remaining program
       }
      void CPT::findbox()
       {
          QWidget  *fwin=new QWidget;
           //other widgets added to it
           //fwin->show();
           static fwin *form2 = new fwin(this);
           form2->show();
           form2->activateWindow(); // or form2->setActiveWindow() in Qt3
           form2->raise();
        }

To copy to clipboard, switch view to plain text mode 

And I got the following errors:

"cptdebug.cpp", line 1501: Error: fwin, of type int, was previously declared QWidget*.
"cptdebug.cpp", line 1501: Error: Multiple declaration for fwin.
"cptdebug.cpp", line 1501: Error: "," expected instead of "*".
"cptdebug.cpp", line 1502: Error: form2 is not defined.
"cptdebug.cpp", line 1503: Error: form2 is not defined.
"cptdebug.cpp", line 1504: Error: form2 is not defined.

Kindly tell me why? And give me the possible solution.

Thanks and regards,
Sarma.

[wysota]

The compiler already told you why...

void CPT::findbox(){
           static fwin *form2 = new fwin(this);
           form2->show();
           form2->activateWindow();
           form2->raise();
}

void CPT::findbox(){
           static fwin *form2 = new fwin(this);
           form2->show();
           form2->activateWindow();
           form2->raise();
}

To copy to clipboard, switch view to plain text mode 

[Sarma]

Sir,
sorry for troubling you much. I couldnot get the proper solution.Please show the changes that I have to make in my code.

regards,
Sarma.

[wysota]

Well, I gave you the code in the previous post. What else do you want?

[Sarma]

hello Sir,
I have posted this thread long back but I couldnot get proper solution.

See the FAQ.

In that FAQ, it was written that "Assuming you have two form classes: Form1 and Form2 and that Form1 has a pushbutton "button" child and Form2 is derived from QDialog" .

But in my application, the find box which I want to show is not derived from QDialog. It is a widget to which many child widgets are added.
Here is the code that I have written:

CPT::CPT(QWidget  *parent):QWidget (parent)
{
   QPushButton *findbut=new QPushButton(this);
   QObject::connect(findbut,SIGNAL(clicked()),this,SLOT(findstr()));
}
 
void CPT::findstr()
{
  QWidget *fwin=new QWidget;
  fwin->setCaption("CP Trace Debug Tool : FIND");
  fwin->setFixedSize(320,125);
  fwin->setFont(QFont("SansSerif",9));  
  fwin->setBackgroundColor(c1);
 
  QVBoxLayout *fvbox=new QVBoxLayout(fwin);
  fvbox->setMargin(2);
  fvbox->setSpacing(6);  
 
  QHBoxLayout *fhbox1=new QHBoxLayout(fvbox);
  fhbox1->setMargin(2);
  fhbox1->setSpacing(8);
 
  QLabel *fl1=new QLabel("Find:",fwin);
  fl1->setBackgroundColor(c1);  
 
  fedit1=new QLineEdit(fwin);
 
  fch=new QCheckBox("Regular Expression",fwin);
  fch->setBackgroundColor(c1);
 
  fhbox1->addWidget(fl1);
  fhbox1->addWidget(fedit1);
  fhbox1->addWidget(fch);
 
  QHBoxLayout *fhbox2=new QHBoxLayout(fvbox);
  fhbox2->setMargin(2);
  fhbox2->setSpacing(6);
 
  QPushButton *fb1=new QPushButton("Forward",fwin);
  fb1->setPaletteBackgroundColor(c1);
 
  QPushButton *fb2=new QPushButton("Backward",fwin);
  fb2->setPaletteBackgroundColor(c1);
 
  QPushButton *fb3=new QPushButton("Close",fwin);
  fb3->setPaletteBackgroundColor(c1);
 
  QObject::connect(fb1,SIGNAL(clicked()),this,SLOT(result_for()));
  QObject::connect(fb2,SIGNAL(clicked()),this,SLOT(result_bck()));
  QObject::connect(fb3,SIGNAL(clicked()),fwin,SLOT(close()));
 
  fhbox2->addWidget(fb1);
  fhbox2->addWidget(fb2);
  fhbox2->addWidget(fb3);
 
  fwin->show();
}

CPT::CPT(QWidget  *parent):QWidget (parent)
{
   QPushButton *findbut=new QPushButton(this);
   QObject::connect(findbut,SIGNAL(clicked()),this,SLOT(findstr()));
}

void CPT::findstr()
{
  QWidget *fwin=new QWidget;
  fwin->setCaption("CP Trace Debug Tool : FIND");
  fwin->setFixedSize(320,125);
  fwin->setFont(QFont("SansSerif",9));  
  fwin->setBackgroundColor(c1);

  QVBoxLayout *fvbox=new QVBoxLayout(fwin);
  fvbox->setMargin(2);
  fvbox->setSpacing(6);  

  QHBoxLayout *fhbox1=new QHBoxLayout(fvbox);
  fhbox1->setMargin(2);
  fhbox1->setSpacing(8);

  QLabel *fl1=new QLabel("Find:",fwin);
  fl1->setBackgroundColor(c1);  

  fedit1=new QLineEdit(fwin);

  fch=new QCheckBox("Regular Expression",fwin);
  fch->setBackgroundColor(c1);
 
  fhbox1->addWidget(fl1);
  fhbox1->addWidget(fedit1);
  fhbox1->addWidget(fch);
 
  QHBoxLayout *fhbox2=new QHBoxLayout(fvbox);
  fhbox2->setMargin(2);
  fhbox2->setSpacing(6);

  QPushButton *fb1=new QPushButton("Forward",fwin);
  fb1->setPaletteBackgroundColor(c1);

  QPushButton *fb2=new QPushButton("Backward",fwin);
  fb2->setPaletteBackgroundColor(c1);

  QPushButton *fb3=new QPushButton("Close",fwin);
  fb3->setPaletteBackgroundColor(c1);

  QObject::connect(fb1,SIGNAL(clicked()),this,SLOT(result_for()));
  QObject::connect(fb2,SIGNAL(clicked()),this,SLOT(result_bck()));
  QObject::connect(fb3,SIGNAL(clicked()),fwin,SLOT(close()));

  fhbox2->addWidget(fb1);
  fhbox2->addWidget(fb2);
  fhbox2->addWidget(fb3);

  fwin->show();
}

To copy to clipboard, switch view to plain text mode 

Now when I press the button again and again, I get multiple windows of this findbox which I shouldn't. Kindly give me the possible solution.

Thanks & Regards,
Sarma.

[jpn]

You are always creating a new find dialog each and every time the button is pressed.
Move the find widget as a member variable, instantiate it only once, and connect the find buttons clicked() signal to the find widget's show() slot.

CPT::CPT(QWidget  *parent):QWidget (parent)
{
	createFind();
	QPushButton *findbut=new QPushButton(this);
	QObject::connect(findbut,SIGNAL(clicked()),fwin,SLOT(show()));
}
 
void CPT::createFind()
{
	// add "QWidget* fwin" as a member variable
	fwin=new QWidget;
	fwin->setCaption("CP Trace Debug Tool : FIND");
	fwin->setFixedSize(320,125);
	fwin->setFont(QFont("SansSerif",9)); 
	fwin->setBackgroundColor(c1);
 
	QVBoxLayout *fvbox=new QVBoxLayout(fwin);
	fvbox->setMargin(2);
	fvbox->setSpacing(6); 
 
	QHBoxLayout *fhbox1=new QHBoxLayout(fvbox);
	fhbox1->setMargin(2);
	fhbox1->setSpacing(8);
 
	QLabel *fl1=new QLabel("Find:",fwin);
	fl1->setBackgroundColor(c1); 
 
	fedit1=new QLineEdit(fwin);
 
	fch=new QCheckBox("Regular Expression",fwin);
	fch->setBackgroundColor(c1);
 
	fhbox1->addWidget(fl1);
	fhbox1->addWidget(fedit1);
	fhbox1->addWidget(fch);
 
	QHBoxLayout *fhbox2=new QHBoxLayout(fvbox);
	fhbox2->setMargin(2);
	fhbox2->setSpacing(6);
 
	QPushButton *fb1=new QPushButton("Forward",fwin);
	fb1->setPaletteBackgroundColor(c1);
 
	QPushButton *fb2=new QPushButton("Backward",fwin);
	fb2->setPaletteBackgroundColor(c1);
 
	QPushButton *fb3=new QPushButton("Close",fwin);
	fb3->setPaletteBackgroundColor(c1);
 
	QObject::connect(fb1,SIGNAL(clicked()),this,SLOT(result_for()));
	QObject::connect(fb2,SIGNAL(clicked()),this,SLOT(result_bck()));
	QObject::connect(fb3,SIGNAL(clicked()),fwin,SLOT(close()));
 
	fhbox2->addWidget(fb1);
	fhbox2->addWidget(fb2);
	fhbox2->addWidget(fb3);
 
	// removed this
	// fwin->show();
}

CPT::CPT(QWidget  *parent):QWidget (parent)
{
	createFind();
	QPushButton *findbut=new QPushButton(this);
	QObject::connect(findbut,SIGNAL(clicked()),fwin,SLOT(show()));
}

void CPT::createFind()
{
	// add "QWidget* fwin" as a member variable
	fwin=new QWidget;
	fwin->setCaption("CP Trace Debug Tool : FIND");
	fwin->setFixedSize(320,125);
	fwin->setFont(QFont("SansSerif",9)); 
	fwin->setBackgroundColor(c1);

	QVBoxLayout *fvbox=new QVBoxLayout(fwin);
	fvbox->setMargin(2);
	fvbox->setSpacing(6); 

	QHBoxLayout *fhbox1=new QHBoxLayout(fvbox);
	fhbox1->setMargin(2);
	fhbox1->setSpacing(8);

	QLabel *fl1=new QLabel("Find:",fwin);
	fl1->setBackgroundColor(c1); 

	fedit1=new QLineEdit(fwin);

	fch=new QCheckBox("Regular Expression",fwin);
	fch->setBackgroundColor(c1);

	fhbox1->addWidget(fl1);
	fhbox1->addWidget(fedit1);
	fhbox1->addWidget(fch);

	QHBoxLayout *fhbox2=new QHBoxLayout(fvbox);
	fhbox2->setMargin(2);
	fhbox2->setSpacing(6);

	QPushButton *fb1=new QPushButton("Forward",fwin);
	fb1->setPaletteBackgroundColor(c1);

	QPushButton *fb2=new QPushButton("Backward",fwin);
	fb2->setPaletteBackgroundColor(c1);

	QPushButton *fb3=new QPushButton("Close",fwin);
	fb3->setPaletteBackgroundColor(c1);

	QObject::connect(fb1,SIGNAL(clicked()),this,SLOT(result_for()));
	QObject::connect(fb2,SIGNAL(clicked()),this,SLOT(result_bck()));
	QObject::connect(fb3,SIGNAL(clicked()),fwin,SLOT(close()));

	fhbox2->addWidget(fb1);
	fhbox2->addWidget(fb2);
	fhbox2->addWidget(fb3);

	// removed this
	// fwin->show();
}

To copy to clipboard, switch view to plain text mode 

[Sarma]

hi jpn,
well thanks for replying.But that didnot solve my problem. Actually, I didnot put the entire code before you( sorry for that ). Thing is that I need to set certain values before createFind() is called. So, I have the code like( with the changes suggested by you ):

CPT::CPT(QWidget *parent):QWidget(parent) 
{
   QPushButton *findbox=new QPushButton();
   QObject::connect(findbox,SIGNAL(clicked()),this,SLOT(defaults()));
}
 
void CPT::defaults()
{
   //setting values for some variables (of integer type)
   createFind();
   fwin->show();
}
 
 void CPT::createFind()
{
  //QWidget *fwin is made as a member variable
  fwin=new QWidget;
  fwin->setCaption("CP Trace Debug Tool : FIND");
  fwin->setFixedSize(320,125);
  fwin->setFont(QFont("SansSerif",9));  
  fwin->setBackgroundColor(c1);
 
  QVBoxLayout *fvbox=new QVBoxLayout(fwin);
  fvbox->setMargin(2);
  fvbox->setSpacing(6);  
 
  QHBoxLayout *fhbox1=new QHBoxLayout(fvbox);
  fhbox1->setMargin(2);
  fhbox1->setSpacing(8);
 
  QLabel *fl1=new QLabel("Find:",fwin);
  fl1->setBackgroundColor(c1);  
 
  fedit1=new QLineEdit(fwin);
 
  fch=new QCheckBox("Regular Expression",fwin);
  fch->setBackgroundColor(c1);
 
  fhbox1->addWidget(fl1);
  fhbox1->addWidget(fedit1);
  fhbox1->addWidget(fch);
 
  QHBoxLayout *fhbox2=new QHBoxLayout(fvbox);
  fhbox2->setMargin(2);
  fhbox2->setSpacing(6);
 
  QPushButton *fb1=new QPushButton("Forward",fwin);
  fb1->setPaletteBackgroundColor(c1);
 
  QPushButton *fb2=new QPushButton("Backward",fwin);
  fb2->setPaletteBackgroundColor(c1);
 
  QPushButton *fb3=new QPushButton("Close",fwin);
  fb3->setPaletteBackgroundColor(c1);
 
  QObject::connect(fb1,SIGNAL(clicked()),this,SLOT(result_for()));
  QObject::connect(fb2,SIGNAL(clicked()),this,SLOT(result_bck()));
  QObject::connect(fb3,SIGNAL(clicked()),fwin,SLOT(close()));
 
  fhbox2->addWidget(fb1);
  fhbox2->addWidget(fb2);
  fhbox2->addWidget(fb3);
 
  //  fwin->show();
}

CPT::CPT(QWidget *parent):QWidget(parent) 
{
   QPushButton *findbox=new QPushButton();
   QObject::connect(findbox,SIGNAL(clicked()),this,SLOT(defaults()));
}

void CPT::defaults()
{
   //setting values for some variables (of integer type)
   createFind();
   fwin->show();
}

 void CPT::createFind()
{
  //QWidget *fwin is made as a member variable
  fwin=new QWidget;
  fwin->setCaption("CP Trace Debug Tool : FIND");
  fwin->setFixedSize(320,125);
  fwin->setFont(QFont("SansSerif",9));  
  fwin->setBackgroundColor(c1);

  QVBoxLayout *fvbox=new QVBoxLayout(fwin);
  fvbox->setMargin(2);
  fvbox->setSpacing(6);  

  QHBoxLayout *fhbox1=new QHBoxLayout(fvbox);
  fhbox1->setMargin(2);
  fhbox1->setSpacing(8);

  QLabel *fl1=new QLabel("Find:",fwin);
  fl1->setBackgroundColor(c1);  

  fedit1=new QLineEdit(fwin);

  fch=new QCheckBox("Regular Expression",fwin);
  fch->setBackgroundColor(c1);
 
  fhbox1->addWidget(fl1);
  fhbox1->addWidget(fedit1);
  fhbox1->addWidget(fch);
 
  QHBoxLayout *fhbox2=new QHBoxLayout(fvbox);
  fhbox2->setMargin(2);
  fhbox2->setSpacing(6);

  QPushButton *fb1=new QPushButton("Forward",fwin);
  fb1->setPaletteBackgroundColor(c1);

  QPushButton *fb2=new QPushButton("Backward",fwin);
  fb2->setPaletteBackgroundColor(c1);

  QPushButton *fb3=new QPushButton("Close",fwin);
  fb3->setPaletteBackgroundColor(c1);

  QObject::connect(fb1,SIGNAL(clicked()),this,SLOT(result_for()));
  QObject::connect(fb2,SIGNAL(clicked()),this,SLOT(result_bck()));
  QObject::connect(fb3,SIGNAL(clicked()),fwin,SLOT(close()));

  fhbox2->addWidget(fb1);
  fhbox2->addWidget(fb2);
  fhbox2->addWidget(fb3);

  //  fwin->show();
}

To copy to clipboard, switch view to plain text mode 

Now kindly show me changes that I can make in this program so that at any time only one box should be made visible.

Thanks & Regards,
Sarma.

[jpn]

....and you are still creating the dialog again and again.
You do not want to create a new instance of the dialog every time the button is pressed.

CPT::CPT(QWidget *parent):QWidget(parent)
{
	createFind(); // create the dialog ONLY ONCE
	QPushButton *findbox=new QPushButton();
	QObject::connect(findbox,SIGNAL(clicked()),this,SLOT(find()));
}
 
void CPT::find()
{
	// set your defaults here
	fwin->show();
	fwin->activateWindow();
	fwin->raise();
}
 
void CPT::createFind()
{
	fwin = new QWidget;
	// ...
}

CPT::CPT(QWidget *parent):QWidget(parent)
{
	createFind(); // create the dialog ONLY ONCE
	QPushButton *findbox=new QPushButton();
	QObject::connect(findbox,SIGNAL(clicked()),this,SLOT(find()));
}

void CPT::find()
{
	// set your defaults here
	fwin->show();
	fwin->activateWindow();
	fwin->raise();
}

void CPT::createFind()
{
	fwin = new QWidget;
	// ...
}

To copy to clipboard, switch view to plain text mode 

[Sarma]

sir,
Thank you very much. It is working well. Now I got the point. I was creating an instance of the window everytime I click the button. But here I got a doubt. We are creating the instance of the findbox in the application even before clicking it. Now for any reason if we donot click the button , doesn't that cause memory wastage? Kindly rectify my doubt.

Thanks once again for this useful post,
Sarma.

[fullmetalcoder]

sir,
Thank you very much. It is working well. Now I got the point. I was creating an instance of the window everytime I click the button. But here I got a doubt. We are creating the instance of the findbox in the application even before clicking it. Now for any reason if we donot click the button , doesn't that cause memory wastage? Kindly rectify my doubt.

Thanks once again for this useful post,
Sarma.

No memory leaks caused provided you use destructor wisely to free all used memory...