How to set new Color every time draw() loop is executed?

[Krish]

Hello! Freinds,
I want to set different color whenever draw() loop is executed. Am using this newly created color to set color for the curves. I am trying to increment, decrement the rgb values
say by 1 or 2 but not that much noticeable change Also they shouldn't cross their limit i.e. 0-255.

draw()
{ // r = 10; g = 255; & b = 180; are static & set previously
  color.setRgb(r,g,b);
  ..
  ... // using the color
  ....     
  r += 2;
  g -= 5;
  b -= 8;
}

draw()
{ // r = 10; g = 255; & b = 180; are static & set previously
  color.setRgb(r,g,b);
  ..
  ... // using the color
  ....     
  r += 2;
  g -= 5;
  b -= 8;
}

To copy to clipboard, switch view to plain text mode 

Can anyone please give me a hint how to solve this.
Thanks in advance.

[wysota]

What exactly do you have problems with? For keeping values inside (0,255) bounds you can use qBound() or calculate the values modulus 256, like so:

r = (r+2) % 256;

r = (r+2) % 256;

To copy to clipboard, switch view to plain text mode 

By the way - if your draw() functions actually does some drawing, it might not be a good idea to change the colours inside it - the function might be called when you don't expect it and the colour will change.

[Krish]

Thanks Wysota for replying.
Yes am drawing curves in draw() function. And to distinguish every new curve drawn i need to set different colors for each curve when they are drawn.
Any idea how to do this!!

Thanks again in advance.

[wysota]

How about adding a const QColor &color parameter to the draw function? Where are you calling draw() from?

[Krish]

Sorry to say but i didn't get your idea about "const QColor &color parameter". I mean how can i change their colors to distinguish them on the plot? I am using the color parameter to set curve' s color as

curve[i]->setPen(QPen(color));

curve[i]->setPen(QPen(color));

To copy to clipboard, switch view to plain text mode 

Am calling the draw function from main file i.e. curves.cpp!!

Thanks again.

[wysota]

void draw(const QColor &color){
  setColor(color);
  doTheDrawing();
}

void draw(const QColor &color){
  setColor(color);
  doTheDrawing();
}

To copy to clipboard, switch view to plain text mode 

[Krish]

Thanks Wysota,
But even here i will have to pass different color parameter to the draw() function, so from where to get/generate these different colors everytime dynamically.
Frankly i have to draw more than 60 - 80 curves so how can i get/generate different colors everytime this draw() function is called/executed.
Even there are only 20 predefined QColors!!

Thanks again.

[wysota]

There are 16.7 millions of colours available in Qt's colour space... A simple random will do just fine.

draw( QColor( qrand() % 256, qrand() % 256, qrand() % 256 ) );

draw( QColor( qrand() % 256, qrand() % 256, qrand() % 256 ) );

To copy to clipboard, switch view to plain text mode 

[Krish]

Hey! Wysota,
Thanks for helping me out. Its working now. Now am getting different color of curve each time.

Best Regards.

[Nadia]

Hi,
And maybe someone have any idea how to mix two QColors(adding them give wrong result). Or any idea how to avoid gray color.I also need generate random colours, except gray.

Thanks in advance.

[john_god]

Just assign a qrand() to the r, g, b variables and perform a while cicle, until the randow values are diferent from the range values of the grey color.

In the case of Krish, and if you would have a maxim limit of curves to draw, like 100, another aproach would be to create a array/list of color's. That way you could give the user the change to personalize each curve color.

[Nadia]

Now, I just make simple check whether r, g an b values not equal (instead of while). But there are the colours that are not actually grey but very similar and lays bad on gray. And what does you mean "assign a qrand() to the r, g, b variables? I just do :

srand( time(0) );//somewhere in main
 
//and then in function then generate randoms
QColor crand = QColor(rand()%256, rand()%256, rand()%256);

srand( time(0) );//somewhere in main

//and then in function then generate randoms
QColor crand = QColor(rand()%256, rand()%256, rand()%256);

To copy to clipboard, switch view to plain text mode 

But I think there are should be standard solutions (algorithms) for good colours combinations.

[john_god]

I mean something like:

int r;
int g;
int b;
 
//define the followin values for a range of grey defined by you
int r_upper_grey = ...;
int r_lower_grey = ...;
int g_upper_grey = ...;
int g_lower_grey = ...;
int b_upper_grey = ...;
int b_lower_grey = ...;
 
do 
{
    r= qrand() % 256;
    g= qrand() % 256;
    b= qrand() % 256;
 
}while (  (  r  < r_upper_grey && r > r_lower_grey)  && 
             (  g  < g_upper_grey && g > g_lower_grey)  &&
             (  b  < b_upper_grey && b > b_lower_grey)  );

int r;
int g;
int b;

//define the followin values for a range of grey defined by you
int r_upper_grey = ...;
int r_lower_grey = ...;
int g_upper_grey = ...;
int g_lower_grey = ...;
int b_upper_grey = ...;
int b_lower_grey = ...;

do 
{
    r= qrand() % 256;
    g= qrand() % 256;
    b= qrand() % 256;

}while (  (  r  < r_upper_grey && r > r_lower_grey)  && 
             (  g  < g_upper_grey && g > g_lower_grey)  &&
             (  b  < b_upper_grey && b > b_lower_grey)  );

To copy to clipboard, switch view to plain text mode 

Get the picture ? Define a range of grey to avoid and keep random the numbers
until they out of the grey zone