Suggestions/Ideas about a file browser

[invictus]

QtCentreWiki: Extended Dir View example

Nice example. Thanks.

But one question. When you doubleclick the treeview it will enter the clicked item...but if the item selected isnt the first column it will not enter the correct directory. Any thoughts on that?

[mchara]

connect clicked(const QModelIndex &) or doubleClicked(const QModelIndex &) signal to slot that setRootIndex ( const QModelIndex & ) for index in first column & the same row as passed in signal...

[jpn]

But one question. When you doubleclick the treeview it will enter the clicked item...but if the item selected isnt the first column it will not enter the correct directory. Any thoughts on that?

Thanks for the bug report. It's fixed now.

[invictus]

Speaking of problems...

This is my goTo slot (much like your setRootIndex):

void goTo(const QModelIndex &dir)
{
if(dirModel->isDir(dir))
{
dirView->setRootIndex(dir);
addressField->setText(dirModel->filePath(dir));
upAction->setEnabled(dir.isValid());
}
}

dirView is a QTreeView. The problem is that when the up method is run (which run goTo() with the parent() of the dirView rootIndex like in your example) the program just quits/crashes. If I comment the if(dirView->isDir()) line it works.

[jpn]

Did you notice that I modified the statement which enables/disables "upAction" in the example from

upAction->setEnabled(listView->rootIndex().isValid());

upAction->setEnabled(listView->rootIndex().isValid());

To copy to clipboard, switch view to plain text mode 

to

upAction->setEnabled(!dirModel->fileInfo(listView->rootIndex()).isRoot());

upAction->setEnabled(!dirModel->fileInfo(listView->rootIndex()).isRoot());

To copy to clipboard, switch view to plain text mode 

? The former works on Windows but not on Linux. On Linux, I experienced the same crash youre' talking about. The latter should work on both environments. Unfortunately I don't have a Mac so I don't know for sure if there's any pitfalls on that matter but I believe the latter should take care of it on Mac too..

[invictus]

Yeah, but its on the isDir() that it crashes. I am using windows btw.

Perhaps the problem is that on Windows there is another level above the root ? its a list of partitions like "C:", "D:", etc...

[jpn]

To me this suggests that goTo() get called with an invalid index and QDirModel is missing sufficient checks. Does the example crash too?

[invictus]

To me this suggests that goTo() get called with an invalid index and QDirModel is missing sufficient checks. Does the example crash too?

No...but then again, the example doesn't run model->isDir() on the level above the root (level above root is the list of filesystems on windows). Looks to me that this is a QT problem or something.

[jpn]

No...but then again, the example doesn't run model->isDir() on the level above the root (level above root is the list of filesystems on windows). Looks to me that this is a QT problem or something.

Drives are "root" on Windows:

qDebug() << QFileInfo("C:\\").isRoot(); // "true"

qDebug() << QFileInfo("C:\\").isRoot(); // "true"

To copy to clipboard, switch view to plain text mode 

Notice that QDirModel::isDir() is basically a shortcut for QDirModel::fileInfo().isDir(). Also, calling QDirModel::fileInfo() or QDirModel::isDir() throws an assert when passed an invalid index:

QDirModel model;
QModelIndex index = model.index(0, 0);
model.fileInfo(index.parent()); // "ASSERT: "d->indexValid(index)" in file itemviews\qdirmodel.cpp"

QDirModel model;
QModelIndex index = model.index(0, 0);
model.fileInfo(index.parent()); // "ASSERT: "d->indexValid(index)" in file itemviews\qdirmodel.cpp"

To copy to clipboard, switch view to plain text mode 

So you will have to take care of it yourself that you don't call QDirModel::fileInfo() or QDirModel::isDir() with an invalid index.

[mchara]

Hi,
i had similar problems, when i was writing dirModel with Desktop myComputer & MyDocuments on top level and i'm quite sure that jpn has right there's no bugs on qt and errors you got are caused by passing unexisting modelIndexes to model...

try to check hasIndex() for each QModelIndex you are using - it might be useful to find the error.

[astrude]

hello.// how an i load the files from the file list so that i an get its directory to load the file itself to transfer it to another device..thanks!

[giacomelli.fabio]

Hi I'm doing that thing with the contents of clipboard.. ( a simple enumeration )

const QMimeData *mime = QApplication::clipboard()->mimeData();
if (mime && mime->hasUrls()) {
QStringList fileList;
foreach(QUrl url, mime->urls())
fileList.append(url.toLocalFile());
........
But If clipboard was filled by a windows application I can't know if I I need to copy or cut ..... do you know a trick ????