How to do internationalization of dynamic text?

[montylee]

Wasn't trUtf8() introduced with Qt4.5?

I don't quite see why you don't just copy it by assigning (assuming qsOriginalStr is really a meaningful QString and not just some byte array that was wrongly de/encoded.)

QString temp = qsOriginalStr;

QString temp = qsOriginalStr;

To copy to clipboard, switch view to plain text mode 

trUtf8() is in Qt 4.4 too. If i assign qsOriginalStr directly, it gives me junk characters, so i have to use trUtf8() to get the proper encoded string.

QString temp = qsOriginalStr.toUtf8();

QString temp = qsOriginalStr.toUtf8();

To copy to clipboard, switch view to plain text mode 

This code will produce a QByteArray with the UTF-8 encoding of your string. Those bytes will then (by the default encoding, whatever that might be in your case) converted back into a string. Quite plausible that this will not get you what you want.

This was the existing code which wasn't written by me.

QString temp = trUtf8(qsOriginalStr);

QString temp = trUtf8(qsOriginalStr);

To copy to clipboard, switch view to plain text mode 

To be honest, I don't see how that should compile either.
Looking at the sources trUtf8 wants a char* (no overloads for QString; at least not in 4.5.0; and also no implicit QString -> char* casts.)

I don't get any compilation errors so i think it implicitly converts the QString to char *
Should i do like this:

QString temp = trUtf8(qsOriginalStr.toLatin1().data());

QString temp = trUtf8(qsOriginalStr.toLatin1().data());

To copy to clipboard, switch view to plain text mode 

[caduel]

QString temp = trUtf8(qsOriginalStr.toLatin1().data());

QString temp = trUtf8(qsOriginalStr.toLatin1().data());

To copy to clipboard, switch view to plain text mode 

well, it does not really make sense to convert a string into the Latin1 encoding and then tell trUtf8 to pretend that this really is UTF8 encoded data...

The original "string" should be either not a QString but only a QByteArray, or it should already be (as QStrings are) a unicode encoded string and no conversions should be needed.
Where does qsOriginalStr come from?

[montylee]

QString temp = trUtf8(qsOriginalStr.toLatin1().data());

QString temp = trUtf8(qsOriginalStr.toLatin1().data());

To copy to clipboard, switch view to plain text mode 

well, it does not really make sense to convert a string into the Latin1 encoding and then tell trUtf8 to pretend that this really is UTF8 encoded data...

The original "string" should be either not a QString but only a QByteArray, or it should already be (as QStrings are) a unicode encoded string and no conversions should be needed.
Where does qsOriginalStr come from?

qsOriginalStr comes from mysql database. Here's the code:

MYSQL_ROW queryRow;
int queryFields = mysql_num_fields(pQueryResult);
 
 
while( (queryRow = mysql_fetch_row(pQueryResult)) != NULL )
{
	printf("cSqlClient::cSqlQuery:next row\n");
	for( i=0; i < queryFields; i++ )
	{
		qsOriginalStr = QString(queryRow[i]);

MYSQL_ROW queryRow;
int queryFields = mysql_num_fields(pQueryResult);
	
		
while( (queryRow = mysql_fetch_row(pQueryResult)) != NULL )
{
	printf("cSqlClient::cSqlQuery:next row\n");
	for( i=0; i < queryFields; i++ )
	{
		qsOriginalStr = QString(queryRow[i]);

To copy to clipboard, switch view to plain text mode 

This is the existing written by someone else. I think i can just replace

qsOriginalStr = QString(queryRow[i]);

qsOriginalStr = QString(queryRow[i]);

To copy to clipboard, switch view to plain text mode 

by

qsOriginalStr = (char *)(queryRow[i]);

qsOriginalStr = (char *)(queryRow[i]);

To copy to clipboard, switch view to plain text mode 

and use trUtf8 directly on the (char *)