conversion problem

[Petr_Kropotkin]

I do a turtle graphics program and having and a hell of time with it.
Here is the code that gives me problems

void checkpos(char cmd[3])
{
    int count=0;
    int move[5];
    char tmp'
 for(int i=0;i<3;++i)
  if (cmd[i]==',')
     {
     tmp=cmd[i+1];
 
     move[count]=atoi(tmp);
 
  }
}
 
 
This code gets the number of moves in the command  5,x.  I am getting this error:
 
H:/C++_How_To_Program/chap04/Turtle_graphics/main.cpp:95: error: invalid conversion from 'char' to 'const char*'
 
How can I convert the [B]cha[/B]r to an[B] int [/B]and get rid fo the error ?:confused:

void checkpos(char cmd[3])
{
    int count=0;
    int move[5];
    char tmp'
 for(int i=0;i<3;++i)
  if (cmd[i]==',')
     {
     tmp=cmd[i+1];
     
     move[count]=atoi(tmp);
   
  }
}


This code gets the number of moves in the command  5,x.  I am getting this error:

H:/C++_How_To_Program/chap04/Turtle_graphics/main.cpp:95: error: invalid conversion from 'char' to 'const char*'

How can I convert the [B]cha[/B]r to an[B] int [/B]and get rid fo the error ?:confused:

To copy to clipboard, switch view to plain text mode 

[john_god]

You have a error while declaring tmp, notice the ' instead of the ;
and try

move[count]=atoi(&tmp);

move[count]=atoi(&tmp);

To copy to clipboard, switch view to plain text mode 

[caduel]

while that fix might compile, it is wrong.

try

void checkpos(char cmd[3])
{
  int count=0;
  int move[5]; // why an array? this code never can parse more than one...
  const char *tmp;
  for(int i=0;i<3;++i)
      if (cmd[i]==',')
      {
          tmp=&cmd[i+1];
          move[count++]=atoi(tmp);
 // and now? break? cmd can not contain further moves....
 // what about the (skipped) 'x'?
       }
}

void checkpos(char cmd[3])
{
  int count=0;
  int move[5]; // why an array? this code never can parse more than one...
  const char *tmp;
  for(int i=0;i<3;++i)
      if (cmd[i]==',')
      {
          tmp=&cmd[i+1];
          move[count++]=atoi(tmp);
 // and now? break? cmd can not contain further moves....
 // what about the (skipped) 'x'?
       }
}

To copy to clipboard, switch view to plain text mode 

Note that char cmd[3] is quite a limitation and prevents you from parsing stuff like "15,x"

[pitonyak]

I would be inclined to not worry about such low level processing and simply pass strings around. Something more like this:

void simpleRegEx(const QString& s)
{
    QRegExp regExp("(\\d+)\\s*,\\s*(\\S+)");
    if (regExp.indexIn(s) >= 0)
    {
        qDebug(qPrintable(QString("Number = %1").arg(regExp.cap(1).toLong())));
        qDebug(qPrintable(QString("Command = %1").arg(regExp.cap(2))));
    }
}

void simpleRegEx(const QString& s)
{
    QRegExp regExp("(\\d+)\\s*,\\s*(\\S+)");
    if (regExp.indexIn(s) >= 0)
    {
        qDebug(qPrintable(QString("Number = %1").arg(regExp.cap(1).toLong())));
        qDebug(qPrintable(QString("Command = %1").arg(regExp.cap(2))));
    }
}

To copy to clipboard, switch view to plain text mode 

[Petr_Kropotkin]

Thanks all. The problem has been solved.