A little calculator problem

[bijan311]

OK so I started to make a calculator program and was compiling while I was coding (that's why the code isn't complete), and it gave me these errors.

error: invalid conversion from `int' to `const QObject*'
error:   initializing argument 3 of `static bool QObject::connect(const QObject*, const char*, const QObject*, const char*, Qt::ConnectionType)'

error: invalid conversion from `int' to `const QObject*'
error:   initializing argument 3 of `static bool QObject::connect(const QObject*, const char*, const QObject*, const char*, Qt::ConnectionType)'

To copy to clipboard, switch view to plain text mode 

Here is my code.

#include <QApplication>
#include <QPushButton>
#include <QLabel>
#include <QSpinBox>
#include <QLCDNumber>
 
int main(int argc, char *argv[])
{
    QApplication app(argc, argv);
    QLabel *minus = new QLabel("-");
    QPushButton *equal = new QPushButton("Execute");
    QSpinBox *num1 = new QSpinBox;
    QSpinBox *num2 = new QSpinBox;
    QLCDNumber *show = new QLCDNumber(3);
    int calc1, calc2;
 
    QObject::connect(num1, SIGNAL(valueChanged(int)), calc1, SLOT(setValue(int)));
 
    return app.exec();
}

#include <QApplication>
#include <QPushButton>
#include <QLabel>
#include <QSpinBox>
#include <QLCDNumber>

int main(int argc, char *argv[])
{
    QApplication app(argc, argv);
    QLabel *minus = new QLabel("-");
    QPushButton *equal = new QPushButton("Execute");
    QSpinBox *num1 = new QSpinBox;
    QSpinBox *num2 = new QSpinBox;
    QLCDNumber *show = new QLCDNumber(3);
    int calc1, calc2;

    QObject::connect(num1, SIGNAL(valueChanged(int)), calc1, SLOT(setValue(int)));

    return app.exec();
}

To copy to clipboard, switch view to plain text mode 

[dubstar_04]

try:

QObject::connect(num1, SIGNAL(valueChanged(int)), this, SLOT(setValue(int)));

[toutarrive]

You are passing an int (calc1) as third argument while the function is waiting for a QObject.

The error message gives you the proper signature of QObject::connect .
The parameters must be the as follow :
(const QObject*, const char*, const QObject*, const char*, Qt::ConnectionType.

[bijan311]

@Dubstar_04 if i do that how will I get calc 1 to equal the value of the spinbox?

[toutarrive]

Set the calc1 value in your slot setValue(int).

[Lykurg]

Maybe you should tell us first what you want achieve. Because your code is nonsense! And I can't figure out why you what set an integer whenever the value of a spinbox is changed, since you can access that info via QSpinBox::value().

[bijan311]

yah, I know my code is nonesense, that's because it isn't finished. I'm trying to make a program that subtracts the two numbers in the spin-boxes when you press the number.

[bijan311]

OK, so I did this,

QObject::connect(num1, SIGNAL(valueChanged(calc1)), this, SLOT(setValue(calc1)));
    QObject::connect(num2, SIGNAL(valueChanged(calc2)), this, SLOT(setValue(calc2)));

QObject::connect(num1, SIGNAL(valueChanged(calc1)), this, SLOT(setValue(calc1)));
    QObject::connect(num2, SIGNAL(valueChanged(calc2)), this, SLOT(setValue(calc2)));

To copy to clipboard, switch view to plain text mode 

but now it says this,

error: invalid use of `this' in non-member function

error: invalid use of `this' in non-member function

To copy to clipboard, switch view to plain text mode 

Thank you.

[wysota]

Shouldn't you be connecting to the clicked() signal of the "Execute" button then?

[bijan311]

OK, here is the entire code,

#include <QApplication>
#include <QPushButton>
#include <QLabel>
#include <QSpinBox>
#include <QLCDNumber>
#include <QHBoxLayout>
#include <QVBoxLayout>
 
int main(int argc, char *argv[])
{
    QApplication app(argc, argv);
    QLabel *minus = new QLabel("-");
    QPushButton *equal = new QPushButton("Execute");
    QSpinBox *num1 = new QSpinBox;
    QSpinBox *num2 = new QSpinBox;
    QLCDNumber *show = new QLCDNumber(3);
    int calc1, calc2;
 
    QObject::connect(num1, SIGNAL(valueChanged(calc1)), this, SLOT(setValue(calc1)));
    QObject::connect(num2, SIGNAL(valueChanged(calc2)), this, SLOT(setValue(calc2)));
    QObject::connect(equal, SIGNAL(clicked()), show, SLOT(setValue(calc1-calc2)));
 
    QHBoxLayout *layout = new QHBoxLayout;
    layout->addWidget(num1);
    layout->addWidget(minus);
    layout->addWidget(num2);
    layout->addWidget(show);
    QVBoxLayout *mainLayout = new QVBoxLayout;
    mainLayout->addLayout(layout);
    mainLayout->addWidget(equal);
 
    return app.exec();
}

#include <QApplication>
#include <QPushButton>
#include <QLabel>
#include <QSpinBox>
#include <QLCDNumber>
#include <QHBoxLayout>
#include <QVBoxLayout>

int main(int argc, char *argv[])
{
    QApplication app(argc, argv);
    QLabel *minus = new QLabel("-");
    QPushButton *equal = new QPushButton("Execute");
    QSpinBox *num1 = new QSpinBox;
    QSpinBox *num2 = new QSpinBox;
    QLCDNumber *show = new QLCDNumber(3);
    int calc1, calc2;

    QObject::connect(num1, SIGNAL(valueChanged(calc1)), this, SLOT(setValue(calc1)));
    QObject::connect(num2, SIGNAL(valueChanged(calc2)), this, SLOT(setValue(calc2)));
    QObject::connect(equal, SIGNAL(clicked()), show, SLOT(setValue(calc1-calc2)));

    QHBoxLayout *layout = new QHBoxLayout;
    layout->addWidget(num1);
    layout->addWidget(minus);
    layout->addWidget(num2);
    layout->addWidget(show);
    QVBoxLayout *mainLayout = new QVBoxLayout;
    mainLayout->addLayout(layout);
    mainLayout->addWidget(equal);

    return app.exec();
}

To copy to clipboard, switch view to plain text mode 

and here are the errors I receive.

|19|error: invalid use of `this' in non-member function|
|20|error: invalid use of `this' in non-member function|

|19|error: invalid use of `this' in non-member function|
|20|error: invalid use of `this' in non-member function|

To copy to clipboard, switch view to plain text mode 

[wysota]

Well, there is no "this" object when you are not inside any objective code so obviously it won't work. Your connect statements still don't make sense anyway. You can't do mathematical operations there and you can't pass variable names there.

Here is something more reasonable:

class Calculator : public QWidget {
  Q_OBJECT
public:
  Calculator(QWidget *parent = 0) : QWidget(parent){
    minus = new QLabel("-");
    equal = new QPushButton("Execute");
    num1 = new QSpinBox;
    num2 = new QSpinBox;
    show = new QLCDNumber(3);
 
    QHBoxLayout *layout = new QHBoxLayout;
    layout->addWidget(num1);
    layout->addWidget(minus);
    layout->addWidget(num2);
    layout->addWidget(show);
    QVBoxLayout *mainLayout = new QVBoxLayout(this);
    mainLayout->addLayout(layout);
    mainLayout->addWidget(equal);
    connect(equal, SIGNAL(clicked()), show, SLOT(calculate()));
  }
public slots:
  void calculate() {
    show->setValue(num1->value()-num2->value());
  }
private:
  QLabel *minus;
  QPushButton *equal;
  QSpinBox *num1;
  QSpinBox *num2;
  QLCDNumber *show;
};
 
#include "main.moc"
 
int main(int argc, char **argv){
  QApplication app(argc, argv);
  Calculator w;
  w.show();
  return app.exec();
}

class Calculator : public QWidget {
  Q_OBJECT
public:
  Calculator(QWidget *parent = 0) : QWidget(parent){
    minus = new QLabel("-");
    equal = new QPushButton("Execute");
    num1 = new QSpinBox;
    num2 = new QSpinBox;
    show = new QLCDNumber(3);

    QHBoxLayout *layout = new QHBoxLayout;
    layout->addWidget(num1);
    layout->addWidget(minus);
    layout->addWidget(num2);
    layout->addWidget(show);
    QVBoxLayout *mainLayout = new QVBoxLayout(this);
    mainLayout->addLayout(layout);
    mainLayout->addWidget(equal);
    connect(equal, SIGNAL(clicked()), show, SLOT(calculate()));
  }
public slots:
  void calculate() {
    show->setValue(num1->value()-num2->value());
  }
private:
  QLabel *minus;
  QPushButton *equal;
  QSpinBox *num1;
  QSpinBox *num2;
  QLCDNumber *show;
};

#include "main.moc"

int main(int argc, char **argv){
  QApplication app(argc, argv);
  Calculator w;
  w.show();
  return app.exec();
}

To copy to clipboard, switch view to plain text mode 

[bijan311]

now it says

|error: 'class QLCDNumber' has no member named 'setValue'

|error: 'class QLCDNumber' has no member named 'setValue'

To copy to clipboard, switch view to plain text mode 

P.S
Sorry this is taking this long, I am a complete beginner.

[Lykurg]

It's because it has to be

show->display(num1->value()-num2->value());

show->display(num1->value()-num2->value());

To copy to clipboard, switch view to plain text mode 

. A quick look it the documentation helps in such cases.

[bijan311]

sorry, I didn't post these errors and I thought the others would go away but here are all the errors.

|40|error: `QLCDNumber*calculator::show' is private|
|48|error: within this context|
|48|error: `w.calculator::show' cannot be used as a function|

|40|error: `QLCDNumber*calculator::show' is private|
|48|error: within this context|
|48|error: `w.calculator::show' cannot be used as a function|

To copy to clipboard, switch view to plain text mode 

again, sorry if I'm beginning to be a pain.

[wysota]

Call the variable differently. It clashes with the method name (QWidget::show()).

[Lykurg]

Seems to be a name clash, so rename your QLCDNumber to lcdnumber or something else and recompile.

[bijan311]

OK so everything compiled, BUT when it is linking to the .EXE it gives me this error

C:\Program Files\CodeBlocks\MinGW\bin\..\lib\gcc\mingw32\3.4.5\..\..\..\..\include\c++\3.4.5\bits\stl_algobase.h:(.text$_ZN10calculatorD1Ev[calculator::~calculator()]+0xb)||undefined reference to `vtable for calculator'|

C:\Program Files\CodeBlocks\MinGW\bin\..\lib\gcc\mingw32\3.4.5\..\..\..\..\include\c++\3.4.5\bits\stl_algobase.h:(.text$_ZN10calculatorD1Ev[calculator::~calculator()]+0xb)||undefined reference to `vtable for calculator'|

To copy to clipboard, switch view to plain text mode 

[wysota]

Did you remember to run qmake after making changes I initially suggested to the code?

[bijan311]

I'm sorry, I don't know how to make a .moc file, I was playing around in the QT command prompt but I can't get a .moc file.

I've treid qmake, qmake -o file, qmake -v.

[squidge]

Run QMake and then rebuild. That'll create your moc files and even run moc on them