tablewidget text colour

[hollowhead]

I'm trying to set the text colour for selected text in a spreadsheet (tablewidget). I've tried several different methods but none of them compile. First I wrote this code for changing the font. This works fine.

both functions on spreadsheet.cpp

void Spreadsheet::selectCellFont()
{
    QList<QTableWidgetItem *> items = selectedItems();
    if (items.isEmpty()) 
	return;    	// nothing happens if nothing is selected and the dialog doesn't appear
 
        bool ok = false;
    	QFont fnt = QFontDialog::getFont(&ok, font(), this);
 
    if (!ok) // if set to OK nothing is changed
        return;
    foreach (QTableWidgetItem *item, items)
        if(item)
            item->setFont(fnt);
      //  somethingChanged();
 
}

void Spreadsheet::selectCellFont()
{
    QList<QTableWidgetItem *> items = selectedItems();
    if (items.isEmpty()) 
	return;    	// nothing happens if nothing is selected and the dialog doesn't appear

        bool ok = false;
    	QFont fnt = QFontDialog::getFont(&ok, font(), this);

    if (!ok) // if set to OK nothing is changed
        return;
    foreach (QTableWidgetItem *item, items)
        if(item)
            item->setFont(fnt);
      //  somethingChanged();
    
}

To copy to clipboard, switch view to plain text mode 

I then wrote similar code for text colour

void SpreadSheet::selectFontColour()
{
QList<QTableWidgetItem *> items = selectedItems();
 if (items.isEmpty()) 
	return;    	// nothing happens if nothing is selected and the dialog doesn't appear
bool ok = false;
 
QColor col = QColorDialog::getColor(&ok, items->textColor(), this); 
   if (!ok) 
        return;
    foreach (QTableWidgetItem *item, items)
        if (item)          
item->setTextColor(col);
}

void SpreadSheet::selectFontColour()
{
QList<QTableWidgetItem *> items = selectedItems();
 if (items.isEmpty()) 
	return;    	// nothing happens if nothing is selected and the dialog doesn't appear
bool ok = false;

QColor col = QColorDialog::getColor(&ok, items->textColor(), this); 
   if (!ok) 
        return;
    foreach (QTableWidgetItem *item, items)
        if (item)          
item->setTextColor(col);
}

To copy to clipboard, switch view to plain text mode 

with prototypes in Spreadsheet class on spreadsheet.hpp

class Spreadsheet : public QTableWidget
 
{
	Q_OBJECT
 
	public://
 
	Spreadsheet(const QString &fileName = QString(),
                QWidget *parent = 0);
	QString currentLocation() const;
    QString currentFormula() const;
 
	void clear();
	QTableWidgetSelectionRange selectedRange() const;
	bool load(const QString &fileName = QString());
	bool save(const QString &fileName = QString());
	void printHtml(const QString &html);
 
 
	public slots:// 
 
    void selectCellFont();
    void selectFontColour();
// etc

class Spreadsheet : public QTableWidget

{
	Q_OBJECT
	
	public://
	
	Spreadsheet(const QString &fileName = QString(),
                QWidget *parent = 0);
	QString currentLocation() const;
    QString currentFormula() const;
	
	void clear();
	QTableWidgetSelectionRange selectedRange() const;
	bool load(const QString &fileName = QString());
	bool save(const QString &fileName = QString());
	void printHtml(const QString &html);
    
	
	public slots:// 
	
    void selectCellFont();
    void selectFontColour();
// etc

To copy to clipboard, switch view to plain text mode 

I get these errors


src/spreadsheet.cpp:312: error: ‘SpreadSheet’ has not been declared
src/spreadsheet.cpp: In function ‘void selectFontColour()’:
src/spreadsheet.cpp:314: error: ‘selectedItems’ was not declared in this scope
src/spreadsheet.cpp:319: error: base operand of ‘->’ has non-pointer type ‘QList<QTableWidgetItem*>’
src/spreadsheet.cpp:319: error: invalid use of ‘this’ in non-member function

The first one is the most puzzling since the font function works.... Can anyone help?

[zgulser]

Try "QTextEdit{ selection-background-color: red }" .

[hollowhead]

Thanks for your reply but I'm using Qtablewidget not Qtextwidget

I put this line in the clear function which makes the header text blue

item->setTextColor ( Qt::blue );

item->setTextColor ( Qt::blue );

To copy to clipboard, switch view to plain text mode 

but I want to make it interactive.

[zgulser]

Sorry for that little mess

Just replace QTextEdit with QTableView and you better do this from the designer..

By the way is your table is multi selected?

[hollowhead]

Thanks that's OK but I'm not sure tableview is what I want. I want to alter the format of the text?

altering the font was easy using tablewidget but changing its colour is more difficult at least for me.....

[zgulser]

Oh you want to change the color of the text not background of it?

[Lykurg]

Note the difference between Spreadsheet and SpreadSheet. C++ is case sensitive!

And then better use setForeground since setTextColor is obsolete.

[zgulser]

Plus I guess you need to set background color as well since it's default dark blue or something. But I still suggest you to stick with selection-color and selection-background-color.

[hollowhead]

What an idiot! of course it is I must have misstyped it.... It just shows you need someone to look over your code... The only error now is

QColor col = QColorDialog::getColor(&ok, items->textColor(), this);

QColor col = QColorDialog::getColor(&ok, items->textColor(), this);

To copy to clipboard, switch view to plain text mode 

Is still cannot work out to do for this line though even after trying a number of alternatives.



I've tried looking at the documentation but I don't find it helpful, the fontdialog documentation is much better it gives a simple code example which helps.

I assume I need something like

QColor col = QColorDialog::getColor( items = Qt::black, items); 
QColor col = QColorDialog::getColor(&ok, items = Qt::black, items); ??

QColor col = QColorDialog::getColor( items = Qt::black, items); 
QColor col = QColorDialog::getColor(&ok, items = Qt::black, items); ??

To copy to clipboard, switch view to plain text mode 

then

if (!ok) 
        return;
    foreach (QTableWidgetItem *item, items)
        if (item)          
item->setForeground(col);

if (!ok) 
        return;
    foreach (QTableWidgetItem *item, items)
        if (item)          
item->setForeground(col);

To copy to clipboard, switch view to plain text mode 

Any help appreciated.

[Lykurg]

Simply use

QColor col = QColorDialog::getColor(items->at(0)->textColor(), this);

QColor col = QColorDialog::getColor(items->at(0)->textColor(), this);

To copy to clipboard, switch view to plain text mode 

and instead of checking your bool ok use

cal ==items->at(0)->textColor()

cal ==items->at(0)->textColor()

To copy to clipboard, switch view to plain text mode 

And once again the same advice: don't use obsolete members. Use foreground() instead. And see the docs how functions are used, since getting a color is a little bit different from getting a font.

[hollowhead]

Thanks Lykurg and everyone I'm embarrassed to say I've solved it. After straining over the documentation and finding a snippet of code in the C++ GUI programming with QT4 book. I couldn't work out how to set the

const QColor & initial = Qt::colour

const QColor & initial = Qt::colour

To copy to clipboard, switch view to plain text mode 

but I worked from the book I needed

private:
 QColor colour; // where colour is initial

private:
 QColor colour; // where colour is initial

To copy to clipboard, switch view to plain text mode 

and "this" as the functions second arguement then it works fine

Code for anyone else who might need it, setBackground() does the same thing.

void Spreadsheet::selectFontColour()
{
QList<QTableWidgetItem *> items = selectedItems();
 if (items.isEmpty()) 
	return;    	// nothing happens if nothing is selected and the dialog doesn't appear
QColor col = QColorDialog::getColor( colour = Qt::black, this); // set to black since cell background is white just in case
   foreach (QTableWidgetItem *item, items) // if cancel is pressed no change
        if (item)          
item->setForeground(col);
}

void Spreadsheet::selectFontColour()
{
QList<QTableWidgetItem *> items = selectedItems();
 if (items.isEmpty()) 
	return;    	// nothing happens if nothing is selected and the dialog doesn't appear
QColor col = QColorDialog::getColor( colour = Qt::black, this); // set to black since cell background is white just in case
   foreach (QTableWidgetItem *item, items) // if cancel is pressed no change
        if (item)          
item->setForeground(col);
}

To copy to clipboard, switch view to plain text mode 

[Lykurg]

I am sorry to say, but your code did not look nice... You don't have to create a member variable for that. This is a overkill. Just pass a color you like as default. That's it. (And the validation in line 8 is not necessary.) And check if the returned color is valid.

[hollowhead]

Thanks. I'll give it a go.