Write to Threaded Server

[Suncell]

Actually writing to the client does work, but with annoying messages.
When I try to write a reply immediately after receiving a message. (For debug purpose it is solved with a connect.)
Then I got always "QObject: Cannot create children for a parent that is in a different thread." But reply message is send anyway. So i could not care about, but its a kind of distrubing. This error appears with and without moving to thread. Is there a way to fix this problem?

serverthread.cpp

#include "serverthread.h"
 
ServerThread::ServerThread(int socketDescriptor, QObject *parent)
: QThread(parent)
, m_socketDescriptor(socketDescriptor)
{
	qDebug() << currentThreadId ();
}
 
ServerThread::~ServerThread ()
{
	stop();
}
 
void ServerThread::stop()
{
	exit();
}
 
void ServerThread::run()
{
	serverSocket = new ServerTcpSocket();
 
	if (!serverSocket->setSocketDescriptor(m_socketDescriptor)) {
		emit error(serverSocket->error(), serverSocket->errorString());
		qDebug() << "setSocketDescriptor error : " << serverSocket->error() << endl;
		return;
	}
 
	connect(serverSocket, SIGNAL(dataAvailable()), this, SLOT(writeData()));
 
	exec();
}
 
void ServerThread::writeData()
{
	serverSocket->moveToThread(currentThread());
//QObject::moveToThread: Current thread (0x1b102fc0) is not the object's thread (0x1b01b6a0).
//Cannot move to target thread (0x1b01b6a0)
 
        m_mutex.lock();
 
	QString msg = "Message from Server\n";
	qint64 blockSize = msg.size();
 
	serverSocket->write(msg.toAscii().data(),blockSize);
// QObject: Cannot create children for a parent that is in a different thread.
//(Parent is QNativeSocketEngine(0x103df1b0), parent's thread is ServerThread(0x103c2910), current thread is QThread(0x101966a0)
	m_mutex.unlock();
}

#include "serverthread.h"

ServerThread::ServerThread(int socketDescriptor, QObject *parent)
: QThread(parent)
, m_socketDescriptor(socketDescriptor)
{
	qDebug() << currentThreadId ();
}

ServerThread::~ServerThread ()
{
	stop();
}

void ServerThread::stop()
{
	exit();
}

void ServerThread::run()
{
	serverSocket = new ServerTcpSocket();

	if (!serverSocket->setSocketDescriptor(m_socketDescriptor)) {
		emit error(serverSocket->error(), serverSocket->errorString());
		qDebug() << "setSocketDescriptor error : " << serverSocket->error() << endl;
		return;
	}

	connect(serverSocket, SIGNAL(dataAvailable()), this, SLOT(writeData()));

	exec();
}

void ServerThread::writeData()
{
	serverSocket->moveToThread(currentThread());
//QObject::moveToThread: Current thread (0x1b102fc0) is not the object's thread (0x1b01b6a0).
//Cannot move to target thread (0x1b01b6a0)

        m_mutex.lock();

	QString msg = "Message from Server\n";
	qint64 blockSize = msg.size();

	serverSocket->write(msg.toAscii().data(),blockSize);
// QObject: Cannot create children for a parent that is in a different thread.
//(Parent is QNativeSocketEngine(0x103df1b0), parent's thread is ServerThread(0x103c2910), current thread is QThread(0x101966a0)
	m_mutex.unlock();
}

To copy to clipboard, switch view to plain text mode 

[Suncell]

Solved it finally!
Now writing and reading are running in one different thread

I'm thankful for every improvement.

Now the Source code:
multiserver.cpp

#include "multiserver.h"
 
MultiServer::MultiServer(QObject *parent)
: QTcpServer(parent)
{
}
 
MultiServer::~MultiServer()
{
	delete server;
}
 
void MultiServer::incomingConnection(int socketDescriptor)
{
	qDebug() << "MultiServer thread " << QThread::currentThreadId ();
 
    server = new ServerThread(socketDescriptor);
    connect(server, SIGNAL(finished()), server, SLOT(deleteLater()));
    server->start();
}

#include "multiserver.h"

MultiServer::MultiServer(QObject *parent)
: QTcpServer(parent)
{
}

MultiServer::~MultiServer()
{
	delete server;
}

void MultiServer::incomingConnection(int socketDescriptor)
{
	qDebug() << "MultiServer thread " << QThread::currentThreadId ();

    server = new ServerThread(socketDescriptor);
    connect(server, SIGNAL(finished()), server, SLOT(deleteLater()));
    server->start();
}

To copy to clipboard, switch view to plain text mode 

serverthread.cpp

#include "serverthread.h"
 
ServerThread::ServerThread(int socketDescriptor)
: QThread()
, m_socketDescriptor(socketDescriptor)
{
	QObject::moveToThread(this); //destroy the obsolete thread
	qDebug() << "ServerThread " << QThread::currentThreadId ();
}
 
ServerThread::~ServerThread ()
{
	stop();
	delete serverSocket;
}
 
void ServerThread::stop()
{
	this->quit();
    this->wait();
}
 
void ServerThread::run()
{
	serverSocket = new ServerTcpSocket();
 
	if (!serverSocket->setSocketDescriptor(m_socketDescriptor)) {
		emit error(serverSocket->error(), serverSocket->errorString());
		qDebug() << "setSocketDescriptor error : " << serverSocket->error() << endl;
		return;
	}
 
	connect(serverSocket, SIGNAL(dataAvailable()), this, SLOT(writeData()));
 
	this->exec();
}
 
void ServerThread::writeData()
{
 
	qDebug() << "writing thread" << currentThreadId ();
 
	QString msg = "Message from Server\n";//Todo just for debug purpose
	qint64 blockSize = msg.size();//Todo just for debug purpose
 
	serverSocket->write(msg.toAscii().data(),blockSize);
}

#include "serverthread.h"

ServerThread::ServerThread(int socketDescriptor)
: QThread()
, m_socketDescriptor(socketDescriptor)
{
	QObject::moveToThread(this); //destroy the obsolete thread
	qDebug() << "ServerThread " << QThread::currentThreadId ();
}

ServerThread::~ServerThread ()
{
	stop();
	delete serverSocket;
}

void ServerThread::stop()
{
	this->quit();
    this->wait();
}

void ServerThread::run()
{
	serverSocket = new ServerTcpSocket();

	if (!serverSocket->setSocketDescriptor(m_socketDescriptor)) {
		emit error(serverSocket->error(), serverSocket->errorString());
		qDebug() << "setSocketDescriptor error : " << serverSocket->error() << endl;
		return;
	}

	connect(serverSocket, SIGNAL(dataAvailable()), this, SLOT(writeData()));

	this->exec();
}

void ServerThread::writeData()
{

	qDebug() << "writing thread" << currentThreadId ();

	QString msg = "Message from Server\n";//Todo just for debug purpose
	qint64 blockSize = msg.size();//Todo just for debug purpose

	serverSocket->write(msg.toAscii().data(),blockSize);
}

To copy to clipboard, switch view to plain text mode 

servertcpsocket.cpp

#include "servertcpsocket.h"
 
ServerTcpSocket::ServerTcpSocket(QObject *parent)
: QTcpSocket(parent)
{
	buffer = new QBuffer();
	buffer->open(QIODevice::ReadWrite);
 
	connect(this, SIGNAL(readyRead()), this, SLOT(readData()));
 
	connect(this, SIGNAL(disconnected()), this, SLOT(deleteLater()));
}
 
 
void ServerTcpSocket::readData()
{
	qDebug() << "reading thread" << QThread::currentThreadId ();
	qint64 bytes = buffer->write(this->readAll());
	buffer->seek(buffer->pos() - bytes);
	while (buffer->canReadLine())
	{
		QString line = buffer->readLine();
		qDebug() << line;
	}
 
	emit dataAvailable();
}

#include "servertcpsocket.h"

ServerTcpSocket::ServerTcpSocket(QObject *parent)
: QTcpSocket(parent)
{
	buffer = new QBuffer();
	buffer->open(QIODevice::ReadWrite);

	connect(this, SIGNAL(readyRead()), this, SLOT(readData()));

	connect(this, SIGNAL(disconnected()), this, SLOT(deleteLater()));
}


void ServerTcpSocket::readData()
{
	qDebug() << "reading thread" << QThread::currentThreadId ();
	qint64 bytes = buffer->write(this->readAll());
	buffer->seek(buffer->pos() - bytes);
	while (buffer->canReadLine())
	{
		QString line = buffer->readLine();
		qDebug() << line;
	}

	emit dataAvailable();
}

To copy to clipboard, switch view to plain text mode