QCodeEdit

[fullmetalcoder]

I think I just found a couple of bugs.
When using proportional fonts, the horizontal scroll bar appears to significantly under estimate the width of the text and will not allow scrolling to the end of the lines.
Also try this. Move the cursor to the start of a line either by clicking it there or using home. Now hold shift and press down cursor. In every other editor, this moves the cursor down to the start of the next line and selects all of the line that it left. In QCodeEdit it does this but also selects all of the line it moved to, leaving 2 lines completely selected.

Good news : I fixed both issues.
Bad news : my network connection is getting kinda weird (some apps can use it, browser for instance and others fail...) so, as svn hung during the commit I'm not quite sure the content of the repository has been updated properly...

[Usability]

It works now, thanks for that fix

I just suffered using windows again long enough to check this still compiles on MSVC6. There were just two changes needed.

qeditor.cpp line 1120, do not return a value, its a void function.
Similarly 1685.

[Usability]

Hi Fullmetalcoder, I am having trouble refreshing the content of the editor. I did this

QString qsFileName = pEditor->fileName();
pEditor->load(qsFileName);

QString qsFileName = pEditor->fileName();
pEditor->load(qsFileName);

To copy to clipboard, switch view to plain text mode 

and it causes a crash.

The call stack shows

• QEditor::load,
• QEditor::setText,
• QDocument::setText,
• qDeleteAll,
• qDeleteAll,
• QDocumentLineHandle::~QDocumentLineHandle,
• QDocumentPrivate::emitLineDeleted,
• QHash<Key, T>::remove,
• QHash<Key, T>::detach,
• QHash<Key, T>::detach_helper

If I am going about this the right way, hopefully you can bind some event in one of your programs to these two lines and reproduce the crash. If it doesn't just fall out and you need a test case, let me know.