Convert QString into QByteArray and vice versa.

[freely]

Hi
please take a look I explain here perhaps it will help to both of us:

I have some application wroten fully in Qt.
In the application I take input from user from line edits and receive QStrings ( ->text() function of the QLineEdit class ). Then I need to save the input ( QStrings ) encrypted to .txt file on user machine’s hdd.
For that purpose I decided to use simple XOR encryption. So I need to convert QString to QByteArray , after that make XOR between 2 byte arrays – input and encryption key and the result I need to save to .txt file so I convert the result vice versa to QString and put it to file.
Also I need to read from file the encrypted data and to check it in some place in the application. For that purpose I read encrypted from previous user input from .txt file to QString and convert it to QByteArray make decryption on QByteArray, convert the result to QString – and very sorrow I do not receive the same input as before encryption – right side of user input lost!!
Perhaps it is because of incorrect conversion QByteArray – QString and vice versa.
What is strangeous – that only for large strings data lost and for number.
I use UTF8 codec:

codec = QTextCodec::codecForName(“utf8”);

codec = QTextCodec::codecForName(“utf8”);

To copy to clipboard, switch view to plain text mode 

I get user input and write to file:

emailEntered = this->login->lineEdit_email->text();
 
keyEntered = this->login->lineEdit_code->text();

emailEntered = this->login->lineEdit_email->text();

keyEntered = this->login->lineEdit_code->text();

To copy to clipboard, switch view to plain text mode 

I make conversion to QByteArray and encryption:

QString emailToSave = QString::fromUtf8(calculateXor(this->emailEntered.toUtf8(),encryptionKey)); 
 
QString keyToSave = QString::fromUtf8(calculateXor(this->keyEntered.toUtf8(),encryptionKey));

QString emailToSave = QString::fromUtf8(calculateXor(this->emailEntered.toUtf8(),encryptionKey)); 

QString keyToSave = QString::fromUtf8(calculateXor(this->keyEntered.toUtf8(),encryptionKey));

To copy to clipboard, switch view to plain text mode 

I save to file:

QTextStream stream(&file); 
stream.setCodec(this->codec); stream<<‘‘<<emailToSave<<’\n’<<’’<<keyToSave<<’\n’<<’*’<<macAdressToSave<<’\n’; file.close();

QTextStream stream(&file); 
stream.setCodec(this->codec); stream<<‘‘<<emailToSave<<’\n’<<’’<<keyToSave<<’\n’<<’*’<<macAdressToSave<<’\n’; file.close();

To copy to clipboard, switch view to plain text mode 

I read from file:

QTextStream stream( &file );
 stream.setCodec(this->codec);
emailFromFile.clear(); 
keyFromFile.clear(); 
macFromFile.clear(); 
stream>>ch; // ‘*’ 
stream>>ch; // email from file: 
while(ch!=’\n’) 
{ 
emailFromFile.append(ch);
 stream>>ch; 
}
 stream>>ch;
 // ‘*’ 
stream>>ch; // first digit of the coded license key 
while(ch!=’\n’)
 { 
keyFromFile.append(ch);
 stream>>ch;
 } 
stream>>ch; // ‘*’ stream>>ch; 
// first digit of mac from file 
while(!stream.atEnd()) // another while(stream!=’\n’)
 { 
macFromFile.append(ch);
 stream>>ch; 
} 
file.close();

QTextStream stream( &file );
 stream.setCodec(this->codec);
emailFromFile.clear(); 
keyFromFile.clear(); 
macFromFile.clear(); 
stream>>ch; // ‘*’ 
stream>>ch; // email from file: 
while(ch!=’\n’) 
{ 
emailFromFile.append(ch);
 stream>>ch; 
}
 stream>>ch;
 // ‘*’ 
stream>>ch; // first digit of the coded license key 
while(ch!=’\n’)
 { 
keyFromFile.append(ch);
 stream>>ch;
 } 
stream>>ch; // ‘*’ stream>>ch; 
// first digit of mac from file 
while(!stream.atEnd()) // another while(stream!=’\n’)
 { 
macFromFile.append(ch);
 stream>>ch; 
} 
file.close();

To copy to clipboard, switch view to plain text mode 

I decrypt readed data from file:

QString result = QString::fromUtf8(calculateXor(this->emailFromFile.toAscii(),encryptionKey));
 
QString result = QString::fromUtf8(calculateXor(this->keyFromFile.toAscii(),encryptionKey));

QString result = QString::fromUtf8(calculateXor(this->emailFromFile.toAscii(),encryptionKey));

QString result = QString::fromUtf8(calculateXor(this->keyFromFile.toAscii(),encryptionKey));

To copy to clipboard, switch view to plain text mode 

For email I get the same as before encryption, but for key ( another user input ) there is lost numbers at the right
What is the problem? I try to fix it this time…

[high_flyer]

Perhaps it is because of incorrect conversion QByteArray – QString and vice versa.

It is because of the conversion, but the conversion is not incorrect!
QString and QByteArray have many things in common, but they are not the same!
If you read the documentation of the various conversion functions both in QByteArray and QString, you will see notes and warnings about the conversions, and how they are done.
If you need to deal with non textual byte sequences, you will get problems when you convert from QByteArray to QString, since QString will either discard or replace non visible characters, changing the binary meaning of your original bytes!

[freely]

Yes of course it is one of the cases.
I understand Unicode,Asci,Latin,UTF and I have read the Qt Framework documentation
I need to convert QString to QByteArray and vice versa so as not to loose any data while converting

How to accomplish such conversion?

[high_flyer]

I don't think you can, from the simple fact, that QByteArray has non visible ASCII values (or can have).
What you need is not to be able to convert QByteArray to QString, but to apply the functionality you have in QStinrg for your QByteArray data.
As far as I understand it, you will have to implement that your self.

[wysota]

Yes of course it is one of the cases.
I understand Unicode,Asci,Latin,UTF and I have read the Qt Framework documentation
I need to convert QString to QByteArray and vice versa so as not to loose any data while converting

How to accomplish such conversion?

But why exactly do you want this conversion to take place? If you want to xor the string then just do it. Each QChar is a 16 bit value, just xor it with 16 bits of your key and you'll get two 8b values that you can store in the byte array.

QByteArray xorEncrypt(const QString &string, const QByteArray &key){
  QByteArray result;
  int keyIndex = 0;
  for(int i=0;i<string.size();++i){
    quint16 val = string.at(i).unicode();
    char high = key.at(keyIndex++);
    if(keyIndex==key.size()) keyIndex = 0;
    char low = key.at(keyIndex++);
    if(keyIndex==key.size()) keyIndex = 0;
    quint16 keyPiece = ((high & 0xFF) << 8) | (low & 0xFF));
    quint16 encoded = val ^ keyPiece;
    result.append(encoded >> 8);
    result.append(encoded & 0xFF);
  }
  return result;
}

QByteArray xorEncrypt(const QString &string, const QByteArray &key){
  QByteArray result;
  int keyIndex = 0;
  for(int i=0;i<string.size();++i){
    quint16 val = string.at(i).unicode();
    char high = key.at(keyIndex++);
    if(keyIndex==key.size()) keyIndex = 0;
    char low = key.at(keyIndex++);
    if(keyIndex==key.size()) keyIndex = 0;
    quint16 keyPiece = ((high & 0xFF) << 8) | (low & 0xFF));
    quint16 encoded = val ^ keyPiece;
    result.append(encoded >> 8);
    result.append(encoded & 0xFF);
  }
  return result;
}

To copy to clipboard, switch view to plain text mode 

Decoding is similar, you just need to reassemble the string.

Of course be aware that xor is a very lousy "cipher" that can be broken within a couple of seconds, especially when encoding data consisting mostly of 0x00:
0x00 xor SECRET = SECRET

The easiest way to break xor is to feed it with a message (either plaintext or ciphertext) consisting of zeroes. Then the key will reveal itself during encryption/decryption.