Maintaining Aspect Ratio of Image in Qt

[anda_skoa]

Line 4 loads them image, it does not scale it at all.
Line 5 is a very expensive NOOP, you are creating a scaled version of the image and then ignore it (return value not used at all).
In Line 6 is another unneeded operation, i.e. toImage(). If you want to work with QImage, use QImage instead of QPixmap. Right now you convert from image to pixmap (internally in line 4) and then back again in line 6.

Cheers,
_

[rohitkk]

Line 4 loads them image, it does not scale it at all.

Yeah I know this.

Line 5 is a very expensive NOOP, you are creating a scaled version of the image and then ignore it (return value not used at all).

What is the right way to do it?
Does storing the returned value really helps?

In Line 6 is another unneeded operation, i.e. toImage(). If you want to work with QImage, use QImage instead of QPixmap. Right now you convert from image to pixmap (internally in line 4) and then back again in line 6.

I have used QByteArray to retrieve image from the database (present as BLOB in db) hence, i am not converting the image i am loading the data (present in QByteArray datatype) into the QPixMap.
I have used QPixMap instead of the QImage because i want to maintain the aspect ratio , as it cannot be done using the QImage (I have tried it before & Image was coming distorted using QImage) & hence, again converting the QPixMap to QImage to display it on the QPainter .

[anda_skoa]

Does storing the returned value really helps?

It helps if you want to use the scaled image. If your goal is to use CPU time then you can of course ignore the result.
However, from your general description it sounds like you want the scaled image, not the original.

I have used QByteArray to retrieve image from the database (present as BLOB in db) hence, i am not converting the image i am loading the data (present in QByteArray datatype) into the QPixMap.

Loading is always done through QImage, so loading into QPixmap loads into a QImage and then converts it to a QPixmap.

I have used QPixMap instead of the QImage because i want to maintain the aspect ratio

What?
Qimage::scaled() takes the same arguments.

Cheers,
_

[rohitkk]

Ok .
I have modified my Code.

QImage img;
if (img.loadFromData(schoolLogo)) {
               reportPainter->drawImage(QRect(60,0,120,60),img.scaled(img.size(),Qt::KeepAspectRatio));
}

QImage img;
if (img.loadFromData(schoolLogo)) {
               reportPainter->drawImage(QRect(60,0,120,60),img.scaled(img.size(),Qt::KeepAspectRatio));
}

To copy to clipboard, switch view to plain text mode 

Please see the screenshot for ,
screen 1 : my actual Image (.jpg)images (1).jpg
screen 2: In my pdf that I have generated containing that picture Untitled.jpg

Hence, in screen 1 viz the actual image , have different height & width.
whereas in screen 2 viz the image on the pdf , where the aspect ratio is not at all maintained.

Please help me out to maintain the aspect ratio of the image & why isn't the Qt::KeepAspectRatio not working as desired?

Thanks in advanced.

Regards,
Rohit

[anda_skoa]

What do you think this part of the code does?

img.scaled(img.size(),Qt::KeepAspectRatio)

img.scaled(img.size(),Qt::KeepAspectRatio)

To copy to clipboard, switch view to plain text mode 

I.e. in words, what do you expect as the return value of img.scaled()?


Cheers,
_

[kapoorsudhish]

Try this as it worked for me:

//viewWidth,viewHeight is the size of the image in the aspect ratio needed.
    image = im.scaled(viewWidth,viewHeight,Qt::IgnoreAspectRatio,Qt::SmoothTransformation);

//viewWidth,viewHeight is the size of the image in the aspect ratio needed.
    image = im.scaled(viewWidth,viewHeight,Qt::IgnoreAspectRatio,Qt::SmoothTransformation);

To copy to clipboard, switch view to plain text mode 

[rohitkk]

What do you think this part of the code does?

img.scaled(img.size(),Qt::KeepAspectRatio)

img.scaled(img.size(),Qt::KeepAspectRatio)

To copy to clipboard, switch view to plain text mode 

What is the correct way to do it?
As you know I have fixed size rectangle,

QRect(60,0,120,60)

QRect(60,0,120,60)

To copy to clipboard, switch view to plain text mode 

And I want to display the image in this rectangle with it's aspect ratio maintained.

I.e. in words, what do you expect as the return value of img.scaled()?

A scaled Image . Right?

[anda_skoa]

What is the correct way to do it?

Correct depends on the desired outcome.
Your code is correct if you want an expensive copy of the original image.

As you know I have fixed size rectangle,

QRect(60,0,120,60)

QRect(60,0,120,60)

To copy to clipboard, switch view to plain text mode 

Which is why I was wondering why you are not using that size instead of the image's own size.

A scaled Image . Right?

Yes, scaled to exactly the same size.

I have troubles understanding why you are not passing the size you want to scale to.


Cheers,
_