Adding values into a table - "Parameter count mismatch" error in SQLite

[Lale123]

Hi all,
I have being trying to create a program to Add Users, Update and Delete Users. Update and Delete parts are working finely. But when I run the Add Users, it displays an error saying "Parameter count mismatch".
your help is highly appreciated

database table-
CREATE TABLE "users" (
"id" integer PRIMARY KEY AUTOINCREMENT NOT NULL,
"user_id" VARCHAR(20) ,
"name" VARCHAR(50) NOT NULL,
"reg_date" DATETIME DEFAULT CURRENT_DATE,
"designation" VARCHAR(10) NOT NULL,
"password" VARCHAR(20) NOT NULL
);

Code-

void example::AddUser()
{
QString userName_s;
userName_s=ui6->lineEdit->text();


if(userName_s=="")
QMessageBox::warning(this,tr("Warning"),tr("Invali d input !!!"));
else
{
QString id_s=this->Increment();
ui6->label_21->setText(id_s);

QSqlQuery query;
query.prepare("INSERT INTO users (user_id,name,reg_date,designation,password ) VALUES (?,?,?,?,?)");

query.bindValue(":user_id = ", id_s );
query.bindValue(":name", ui6->lineEdit->displayText());
query.bindValue(":reg_date = ",QDate::currentDate().toString("dd-MM-yyyy") );
query.bindValue(":designation", ui6->comboBox->currentText());
query.bindValue(": password = ", id_s );
query.exec();

if (!query.isActive())//checks wether the connection is active
{
QMessageBox::warning(this, tr("Database Error"),
query.lastError().text());
}

this->DisplayAddedUser();

ui6->lineEdit->clear();
ui6->label_21->clear();
}
}

[jefftee]

Hi all,
query.prepare("INSERT INTO users (user_id,name,reg_date,designation,password ) VALUES (?,?,?,?,?)");

query.bindValue(":user_id = ", id_s );
query.bindValue(":name", ui6->lineEdit->displayText());
query.bindValue(":reg_date = ",QDate::currentDate().toString("dd-MM-yyyy") );
query.bindValue(":designation", ui6->comboBox->currentText());
query.bindValue(": password = ", id_s );
query.exec();

You are mixing named and unnamed query parameters. Either replace the question marks in your query string with the named parameters or leave the query ASIS and use the QSqlQuery::bindValue overload that uses the positional parameters.

Also, please use [code] and [/code] when pasting code examples.

[Lale123]

Thanks for the kind help jthomps!!

[jefftee]

No problem, glad to help. I did want to mention that if you are going to use named query parameters, the bindValue is just the parameter name. In your example, you have " = " as part of the parameter name, it should be something like:

query.prepare("INSERT INTO users (user_id,name,reg_date,designation,password ) VALUES (:user_id,:name,:reg_date,:designation,:password)");
 
query.bindValue(":user_id", id_s );
query.bindValue(":name", ui6->lineEdit->displayText());
query.bindValue(":reg_date",QDate::currentDate().toString("dd-MM-yyyy") );
query.bindValue(":designation", ui6->comboBox->currentText());
query.bindValue(":password", id_s );
query.exec();

query.prepare("INSERT INTO users (user_id,name,reg_date,designation,password ) VALUES (:user_id,:name,:reg_date,:designation,:password)");

query.bindValue(":user_id", id_s );
query.bindValue(":name", ui6->lineEdit->displayText());
query.bindValue(":reg_date",QDate::currentDate().toString("dd-MM-yyyy") );
query.bindValue(":designation", ui6->comboBox->currentText());
query.bindValue(":password", id_s );
query.exec();

To copy to clipboard, switch view to plain text mode