app crashes again

[sophister]

Hi again, I'm faced with the second application's crash.
Here is my code:

void DishManager::initPage1()
{
    ui.p1FamilyComboBox->addItems(dishes->getFamilies());
}

void DishManager::initPage1()
{
    ui.p1FamilyComboBox->addItems(dishes->getFamilies());
}

To copy to clipboard, switch view to plain text mode 

where p1FamilyComboBox is a instance of

QComboBox

QComboBox

To copy to clipboard, switch view to plain text mode 

, and dishes is an instance of the following class Record.

const QStringList& Record::getDishNamesByFamily(const QString &family) const
{
    QStringList names;
    for(int i = 0; i < dishes.size(); i++)
    {
        if(dishes[i].getFamily() == family)
        {
            names << dishes[i].getName();  //如果某菜谱属于此菜系，则加入其菜名
        }
    }
    return names;
}

const QStringList& Record::getDishNamesByFamily(const QString &family) const
{
    QStringList names;
    for(int i = 0; i < dishes.size(); i++)
    {
        if(dishes[i].getFamily() == family)
        {
            names << dishes[i].getName();  //如果某菜谱属于此菜系，则加入其菜名
        }
    }
    return names;
}

To copy to clipboard, switch view to plain text mode 

I think maybe it's due to the

const QStringList& Record::getDishNamesByFamily

const QStringList& Record::getDishNamesByFamily

To copy to clipboard, switch view to plain text mode 

Is there anything wrong with the returning value.
Thanks in advance!!

[nish]

change

const QStringList& Record::getDishNamesByFamily()

const QStringList& Record::getDishNamesByFamily()

To copy to clipboard, switch view to plain text mode 

to

QStringList Record::getDishNamesByFamily()

QStringList Record::getDishNamesByFamily()

To copy to clipboard, switch view to plain text mode 

阅读有关悬挂指针（引用）

[sophister]

Oh, thank you!!
You know Chinese Simplified!!（简体中文）.
But I do not realize it would be something with the reference or pointer. C++ is really strange!

[nish]

it is very simple...

the local var
QStringList names;
is destroyed when the function returns... so the pointer(reference) to it(the return type) is pointing to the
illegal memory hence the crash..


Btw .. i just used google translater to translate.. i dont know chinese no matter how simplified it is...

[sophister]

Oh, I see.
Thanks very much!!!

[sophister]

The following codes have any problem??

const QString& getName() const {return name;}

const QString& getName() const {return name;}

To copy to clipboard, switch view to plain text mode 

it is a method of class Dish. name is a member variable of class Dish.
When I do the following, it crashes again:

label.setText(dish.getName());

label.setText(dish.getName());

To copy to clipboard, switch view to plain text mode 

Is this the same problem as above?
Thanks!!

[nish]

it should not crash now... can u write a minimal compilable example reproducing the problem?

[sophister]

thanks.
I have modify my codes.
I remember that it is said in the <Thinking in C++>, that reference is only to be used in function variables. Maybe I overuserd it.