Need help with QToolButton

[philipp1]

Qt 3
I have some window which have a dock window.This dock window creates a QToolBar
mw->addToolBar(); mw it is a pointer to MainWindow.
This function creates ToolBar.
void MainWindow::addToolBar()
{
QToolBar* toolbar_but = new QToolBar("Open puctures",this, DockLeft , TRUE ,0);

}
It works.
When some event happens I must create button on toolbar.
I do it so:
mw->addButton();

void MainWindow::addButton()
{
QToolBar* toolbar_but;
btnpix = new QToolButton(toolbar_but, "");
}
One button it creates.
But when next event happens -> Segmentation fault .
What it could be?

[munna]

try

void MainWindow::addButton()
{
    QToolBar* tb = new QToolButton(DockLeft, "");
}

void MainWindow::addButton()
{
    QToolBar* tb = new QToolButton(DockLeft, "");
}

To copy to clipboard, switch view to plain text mode 

BTW what is btnpix?

[jpn]

Store toolbar_but as a member variable. The toolbar_but in addButton() is different than in addToolBar(). It's just a dangling pointer in addButton().

void MainWindow::addToolBar()
{
        // you should store toolbar_but as a member variable for later usage
        QToolBar* toolbar_but = new QToolBar("Open puctures",this, DockLeft , TRUE ,0);
}
 
void MainWindow::addButton()
{
      // the toolbar_but here is not the same toolbar_but as in addToolBar() !!
      QToolBar* toolbar_but; // this is just a local variable, a dangling pointer pointing nowhere
      btnpix = new QToolButton(toolbar_but, "");  
}

void MainWindow::addToolBar()
{
        // you should store toolbar_but as a member variable for later usage
        QToolBar* toolbar_but = new QToolBar("Open puctures",this, DockLeft , TRUE ,0);
}

void MainWindow::addButton()
{
      // the toolbar_but here is not the same toolbar_but as in addToolBar() !!
      QToolBar* toolbar_but; // this is just a local variable, a dangling pointer pointing nowhere
      btnpix = new QToolButton(toolbar_but, "");  
}

To copy to clipboard, switch view to plain text mode 

[philipp1]

May be I dont understand something but how we can ti convert QToolButton to QToolBar?
For expierence I wrote your code: cannot convert 'QToolButton*' to 'QToolBar*' in initialization.

[munna]

oh sorry that was my mistake.

I actually meant

void MainWindow::addButton()
    {
          QToolButton* tb = new QToolButton(DockLeft, "");
    }

void MainWindow::addButton()
    {
          QToolButton* tb = new QToolButton(DockLeft, "");
    }

To copy to clipboard, switch view to plain text mode 

Sorry once again.

[munna]

Store toolbar_but as a member variable. The toolbar_but in addButton() is different than in addToolBar(). It's just a dangling pointer in addButton().

One button it creates.

It's strange.

[philipp1]

oh sorry that was my mistake.

I actually meant

void MainWindow::addButton()
    {
          QToolButton* tb = new QToolButton(DockLeft, "");
    }

void MainWindow::addButton()
    {
          QToolButton* tb = new QToolButton(DockLeft, "");
    }

To copy to clipboard, switch view to plain text mode 

Sorry once again.

They is no such constructor QToolButton(DockLeft, ""); (I did't find it)

[munna]

oh, I am sorry once again

It should be

void MainWindow::addButton()
   {
         QToolButton* tb = new QToolButton(this);
   }

void MainWindow::addButton()
   {
         QToolButton* tb = new QToolButton(this);
   }

To copy to clipboard, switch view to plain text mode 

Actually I got confused because of the QToolBar consstructor that your are using.

The constructor that you are using is obsolete

void MainWindow::addToolBar()
{
      QToolBar* toolbar_but = new QToolBar("Open puctures",this, DockLeft , TRUE ,0);// this is obsolete
 
}

void MainWindow::addToolBar()
{
      QToolBar* toolbar_but = new QToolBar("Open puctures",this, DockLeft , TRUE ,0);// this is obsolete

}

To copy to clipboard, switch view to plain text mode 

you should rather be using

void MainWindow::addToolBar()
{
      QToolBar* toolbar_but = new QToolBar(this,0);
      toolbar_but->setLabel("Open Pictures");
}

void MainWindow::addToolBar()
{
      QToolBar* toolbar_but = new QToolBar(this,0);
      toolbar_but->setLabel("Open Pictures");
}

To copy to clipboard, switch view to plain text mode 

or may be the other one according to your need.

[philipp1]

Store toolbar_but as a member variable. The toolbar_but in addButton() is different than in addToolBar(). It's just a dangling pointer in addButton().

I understand you. But how can I realise it? Toolbutton belongs to mainwindow and I call him in a dock window.

[jpn]

Sorry, I didn't understand. Realise what? You mean how can it be implemented?

// class declaration
class MainWindow : public ...
{
public:
	...
 
private:
	QToolBar* toolbar_but; // <--- a member variable
};

// class declaration
class MainWindow : public ...
{
public:
	...

private:
	QToolBar* toolbar_but; // <--- a member variable
};

To copy to clipboard, switch view to plain text mode 

// class implementation
void MainWindow::addToolBar()
{
	// store the toolbar as a member variable for later usage
	toolbar_but = new QToolBar("Open puctures",this, DockLeft , TRUE ,0);
}
 
void MainWindow::addButton()
{
	// use the member variable here
	btnpix = new QToolButton(toolbar_but, ""); 
}

// class implementation
void MainWindow::addToolBar()
{
	// store the toolbar as a member variable for later usage
	toolbar_but = new QToolBar("Open puctures",this, DockLeft , TRUE ,0);
}

void MainWindow::addButton()
{
	// use the member variable here
	btnpix = new QToolButton(toolbar_but, ""); 
}

To copy to clipboard, switch view to plain text mode 

[philipp1]

I made as you say from the wery beginning.


class MainWindow : public QMainWindow {
Q_OBJECT

public:
....
QToolBar* toolbar_but;
void addToolBar();
void addButton();

mainwindow.cpp

void MainWindow::addButton()
{
//QToolBar* toolbar_but;
btnpix = new QToolButton(toolbar_but, "");
}

void MainWindow::addToolBar()
{
QToolBar* toolbar_but = new QToolBar("Open puctures",this, DockLeft , TRUE ,0);

[jpn]

I made as you say from the wery beginning.

void MainWindow::addToolBar()
{
    // the problem is in here
    QToolBar* toolbar_but = new QToolBar("Open puctures",this, DockLeft , TRUE ,0);
}

void MainWindow::addToolBar()
{
    // the problem is in here
    QToolBar* toolbar_but = new QToolBar("Open puctures",this, DockLeft , TRUE ,0);
}

To copy to clipboard, switch view to plain text mode 

You are storing the toolbar to a local variable, not to the member variable. It should be:

void MainWindow::addToolBar()
{
    // notice the missing type, you want to use the member variable, not to create a new local variable
    toolbar_but = new QToolBar("Open puctures",this, DockLeft , TRUE ,0);
}

void MainWindow::addToolBar()
{
    // notice the missing type, you want to use the member variable, not to create a new local variable
    toolbar_but = new QToolBar("Open puctures",this, DockLeft , TRUE ,0);
}

To copy to clipboard, switch view to plain text mode 

[philipp1]

You are storing the toolbar to a local variable, not to the member variable. It should be:

void MainWindow::addToolBar()
{
    // notice the missing type, you want to use the member variable, not to create a new local variable
    toolbar_but = new QToolBar("Open puctures",this, DockLeft , TRUE ,0);
}

void MainWindow::addToolBar()
{
    // notice the missing type, you want to use the member variable, not to create a new local variable
    toolbar_but = new QToolBar("Open puctures",this, DockLeft , TRUE ,0);
}

To copy to clipboard, switch view to plain text mode 

Have a great thanks from me. Puting types was my mistake.
//(may be its friday)