mouse pos() returns wrong position

[FlyDoodle]

Hello
thank you for answering, and regarding the mousePressEvent(), its being called in the game class:
This is the code :

void Game::mousePressEvent(QMouseEvent *event)
{
    if(event->buttons() == Qt::RightButton && in_room!="menu"){
 
        QLineF ln(event->pos(),player->pos());
        int angle = -1 * ln.angle() + 460;
 
        int tmp = angle + 80;
        if(tmp>360)
            tmp-=360;
 
        if(angle > 360)
            angle += -360;
 
        player->setPlayerRotation(angle,tmp);
 
        QPointF t(event->pos());
        player->setDestination(t);
 
    }
}

void Game::mousePressEvent(QMouseEvent *event)
{
    if(event->buttons() == Qt::RightButton && in_room!="menu"){
 
        QLineF ln(event->pos(),player->pos());
        int angle = -1 * ln.angle() + 460;
 
        int tmp = angle + 80;
        if(tmp>360)
            tmp-=360;
 
        if(angle > 360)
            angle += -360;
 
        player->setPlayerRotation(angle,tmp);
 
        QPointF t(event->pos());
        player->setDestination(t);
 
    }
}

To copy to clipboard, switch view to plain text mode 

I tried putting :

QPointF t(mapToScene(event->pos()));

QPointF t(mapToScene(event->pos()));

To copy to clipboard, switch view to plain text mode 

But it still doesn't work...

And yeah they are both QGraphicsItem instances in the scene, here is the code if helps :
Land and Water files ( both are the same just the namings are different )

#ifndef LAND_H
#define LAND_H
 
#include <QObject>
#include <QGraphicsPixmapItem>
 
class Land: public QObject, public QGraphicsPixmapItem{
    Q_OBJECT
public:
    Land(QGraphicsPixmapItem *parent=NULL);
 
private:
    QString file_name;
};
 
#endif // LAND_H

#ifndef LAND_H
#define LAND_H

#include <QObject>
#include <QGraphicsPixmapItem>

class Land: public QObject, public QGraphicsPixmapItem{
    Q_OBJECT
public:
    Land(QGraphicsPixmapItem *parent=NULL);

private:
    QString file_name;
};

#endif // LAND_H

To copy to clipboard, switch view to plain text mode 

.cpp

#include "land.h"
 
Land::Land(QGraphicsPixmapItem *parent)
{
    file_name = ":/Images/Land.png";
    setPixmap(QPixmap(file_name));
}

#include "land.h"

Land::Land(QGraphicsPixmapItem *parent)
{
    file_name = ":/Images/Land.png";
    setPixmap(QPixmap(file_name));
}

To copy to clipboard, switch view to plain text mode 

I don't know how to make my mouse event ignore those two classes when pressing right click on them ( so that its like i'm trying to access scene only and get coordinate from it )... I tried looking for the solution on google ( ignore() functions and so on ) and i still have no idea...

[d_stranz]

mousePressEvent(), its being called in the game class

No, it isn't being called there, it is defined there. It is probably being called from Qt's event loop, handling events on the QGraphicsView that are not being handled by other objects.

You should read the Qt documentation on the Qt Graphics View Framework and pay particular attention to the section on "The Graphics View Coordinate System".

You should also be sure that you are handling your mouse events correctly. There is a complete set of mouse and other events that are handled internally in the QGraphicsScene class. These take care of mapping events in the scene to the graphical objects that have the current focus or are under the mouse. If you are handling mouse events at both the widget level (QGraphicsView) and scene level, then the coordinate systems are not the same.

My advice is to handle mouse events only at the scene level (by implementing handlers for your QGraphicsItem-based classes), and map everything to scene coordinates.

[FlyDoodle]

No, it isn't being called there, it is defined there.

oh i see, ye i have to take a look at view, scene and events handling stuff a little bit more, tho after trying some stuff out i realized that when i was creating a line between the player and the mouse i forgot to use mapToScene when initializing points. So far it seems to be working. Thank you very much for that !!

Tho i have one more question, how do i put waves (image) around my island in the game as the background. I want to make it so that for example 60 x 60 pixels waves fill the background. Doing setBackgroundBrush(QBrush(QImage("path"))); will set the background the way i want it to, but the problem is when the player is moving and he gets near the water, he has to stop. I wanted to check if he is near the water using collision. Like that class Land i made class Sea and this class is also QPixmapItem and i could just check if the player has collided with Sea but the problem comes when i want the sea to be moving, cause changing pictures takes time and that's not optimal...

[d_stranz]

cause changing pictures takes time and that's not optimal...

Changing pictures only takes time if you are loading them from disk every time you change. If you keep the pictures in memory in the correct form (QPixmap), then changing the image is as fast as calling setPixmap(). QPixmap instances use data sharing, which means that calling setPixmap() does not involve a data copy of the pixmap, simply swapping an internal reference. There is even a QPixmapCache cache that you can store your pixmaps in.

For detecting if your player has walked into the water, you might be able to use QPolygon to define the area of the land, and QPolygon::containsPoint() to determine if your player is still on land.

[FlyDoodle]

I didn't put QPixmap on the heap, that is why it took couple of seconds to load an image every time. Thank you very much for the help !!!