Trouble with "INSERT" by QSqlTableModel

[AD]

/// Добавление серийного номера
bool AddSerialNumber::add()
{
	/// Иметь в виду, что длина строки = 9 байт. 9-й байт - конец строки. При генерации файла ключа выкидывать 9-й байт
	while(element -> serialName.size() <= 8)
		element -> serialName += (QChar)32;
 
	int model = selectModelID();
 
	QSqlTableModel model;
	model.setTable("DeviceList");
	//model.setEditStrategy(QSqlTableModel::OnManualSubmit);
	model.select();
	int row = model.rowCount();
	bool k = model.insertRow(row);
	model.setData(model.index(row, 0), element -> serialName);
	model.setData(model.index(row, 1), element -> secret);
	model.setData(model.index(row, 2), true);
	model.setData(model.index(row, 3), modelID);
	bool ins = model.submitAll();
	string err = model.lastError().text().toStdString();
 
	return ins;
}

/// Добавление серийного номера
bool AddSerialNumber::add()
{
	/// Иметь в виду, что длина строки = 9 байт. 9-й байт - конец строки. При генерации файла ключа выкидывать 9-й байт
	while(element -> serialName.size() <= 8)
		element -> serialName += (QChar)32;

	int model = selectModelID();

	QSqlTableModel model;
	model.setTable("DeviceList");
	//model.setEditStrategy(QSqlTableModel::OnManualSubmit);
	model.select();
	int row = model.rowCount();
	bool k = model.insertRow(row);
	model.setData(model.index(row, 0), element -> serialName);
	model.setData(model.index(row, 1), element -> secret);
	model.setData(model.index(row, 2), true);
	model.setData(model.index(row, 3), modelID);
	bool ins = model.submitAll();
	string err = model.lastError().text().toStdString();

	return ins;
}

To copy to clipboard, switch view to plain text mode 

This code does not insert record in table. I don't understand - why? That code is executed:

// Добавление серийного номера
bool AddSerialNumber::add()
{
	while(element -> serialName.size() <= 8)
		element -> serialName += (QChar)32;
 
	int modelID = selectModelID();
	QSqlQuery query;
	QString insert_query1 = QString("insert into DeviceList(serialNumber, secretKey, security, modelID) "
		"values('%1', '%2', %3, %4)").arg(element -> serialName).arg(element -> secret).arg(true).arg(modelID);
	bool ins = query.exec(insert_query1);
 
	return ins;
}

// Добавление серийного номера
bool AddSerialNumber::add()
{
	while(element -> serialName.size() <= 8)
		element -> serialName += (QChar)32;

	int modelID = selectModelID();
	QSqlQuery query;
	QString insert_query1 = QString("insert into DeviceList(serialNumber, secretKey, security, modelID) "
		"values('%1', '%2', %3, %4)").arg(element -> serialName).arg(element -> secret).arg(true).arg(modelID);
	bool ins = query.exec(insert_query1);

	return ins;
}

To copy to clipboard, switch view to plain text mode 

What is wrong? Why do I can't use QSqlTableModel?

[caduel]

there is a bug in Qt that might be related to this: http://trolltech.com/developer/task-...ntry&id=227468
(check your debug output for "No fields to update.")

Try if your code works with Qt 4.4.0

HTH

[AD]

there is a bug in Qt that might be related to this: http://trolltech.com/developer/task-...ntry&id=227468
(check your debug output for "No fields to update.")

Try if your code works with Qt 4.4.0

HTH

My code works with Qt 4.3.2. Can I use QSqlTableModel for INSERT, UPDATE?

[caduel]

My code works with Qt 4.3.2. Can I use QSqlTableModel for INSERT, UPDATE?

sure.
(of course, only with a Qt version that is not buggy here. i.e. <= 4.4.0 and hopefully >= 4.4.4)

[AD]

sure.
(of course, only with a Qt version that is not buggy here. i.e. <= 4.4.0 and hopefully >= 4.4.4)

Where are errors? Why my code doesn't work i.e. submitAll return false for INSERT. Why?

[caduel]

possibilites
i) the bug i mentioned (or some other bug)
ii) did you check the columns match the order matches your inserts?

Is there any debug output that you get?
What error is returned (if any)?

[AD]

Error

[Microsoft][SQL Native Client][SQL Server]Operand type clash: text is incompatible with bit [Microsoft][SQL Native Client][SQL Server]Statement(s) could not be prepared. QODBC3: Unable to execute statement

which geted by

model.lastError()

model.lastError()

To copy to clipboard, switch view to plain text mode 

How can I check the order? I saw mentioned order by Microsoft Sql Express Manager

[caduel]

looks like the order of the fields is not as you expected (seems like column 1 is "security"; you can check by displaying the QSqlTableModel in a QTableView).

How about this approach:
populate (access columns by name) a QSqlRecord (you get an empty one with record()) and insert it with QSqlTableModel::insertRecord()
This way your code does not depend on the order of the columns in the table.

HTH

[AD]

looks like the order of the fields is not as you expected (seems like column 1 is "security"; you can check by displaying the QSqlTableModel in a QTableView).

How about this approach:
populate (access columns by name) a QSqlRecord (you get an empty one with record()) and insert it with QSqlTableModel::insertRecord()
This way your code does not depend on the order of the columns in the table.

HTH

// Добавление серийного номера
bool AddSerialNumber::add()
{
    while(element -> serialName.size() <= 8)
        element -> serialName += (QChar)32;
 
    int modelID = selectModelID();
QSqlTableModel model;model.setTable("DeviceList");
model.setEditStrategy(QSqlTableModel::OnManualSubmit);
model.select();
QSqlRecord record = model.record( );
record.setValue("serialNumber", element -> serialName);
record.setValue("secretKey", element -> secret );
record.setValue("security", true);
record.setValue( "modelID", modelID);
model.insertRecord(-1, record);
bool ins = model.submitAll( );
 
return ins;
}

// Добавление серийного номера
bool AddSerialNumber::add()
{
    while(element -> serialName.size() <= 8)
        element -> serialName += (QChar)32;
 
    int modelID = selectModelID();
QSqlTableModel model;model.setTable("DeviceList");
model.setEditStrategy(QSqlTableModel::OnManualSubmit);
model.select();
QSqlRecord record = model.record( );
record.setValue("serialNumber", element -> serialName);
record.setValue("secretKey", element -> secret );
record.setValue("security", true);
record.setValue( "modelID", modelID);
model.insertRecord(-1, record);
bool ins = model.submitAll( );

return ins;
}

To copy to clipboard, switch view to plain text mode 

This code doesn't works too. submitAll return false

[AD]

Au! Help, please!

[caduel]

any error message / debug output that could help us?

[AD]

This error is:

[Microsoft][SQL Native Client][SQL Server]Operand type clash: text is incompatible with bit [Microsoft][SQL Native Client][SQL Server]Statement(s) could not be prepared. QODBC3: Unable to execute statement

ODBC driver work right. Intructions UPDATE, SELECT works, INSERT with QSqlQuery works!

[caduel]

i) dump the QSqlRecord to stderr, check esp. the QVariant::Types of the fields
ii) if those do not match your db: fix the setValue calls to the record to be inserted
iii) assuming those are correct: file a bug report to the Trolls