compile issue, syntax i guess, but can't find it

[incapacitant]

archiv.h

class Archives : public QDialog
{
    Q_OBJECT
 
public:
  Archives( QWidget *parent = 0 );
  ~Archives();
  QString getFileName( const QModelIndex &);
...

class Archives : public QDialog
{
    Q_OBJECT

public:
  Archives( QWidget *parent = 0 );
  ~Archives();
  QString getFileName( const QModelIndex &);
...

To copy to clipboard, switch view to plain text mode 

archiv.cpp

//****************************************************************
QString Archives::getFileName( const QModelIndex & idx )
{
  return model->data(idx.sibling(idx.row(), 0)).toString();
}

//****************************************************************
QString Archives::getFileName( const QModelIndex & idx )
{
  return model->data(idx.sibling(idx.row(), 0)).toString();
}

To copy to clipboard, switch view to plain text mode 

and menu.cpp

//****************************************************************
void ApplicationWindow::archives()
{
  Archives Archives_dlg( this );
  if ( Archives_dlg.exec() )
  {
     QString s = Archives_dlg->getFileName( const QmodelIndex & idx);
  }  
}

//****************************************************************
void ApplicationWindow::archives()
{
  Archives Archives_dlg( this );
  if ( Archives_dlg.exec() )
  {
     QString s = Archives_dlg->getFileName( const QmodelIndex & idx);
  }  
}

To copy to clipboard, switch view to plain text mode 

and the compiler says :
QString s = Archives_dlg->getFileName( const QmodelIndex & idx);
180 C:\Qt\test\sms\menu.cpp base operand of `->' has non-pointer type `Archives'

in the procedure above I make a similar call with (apparently the same syntax) and it works, so I don't know.

[jpn]

Edit: errr.. use operator "." and you need to also pass a QModelIndex.

QModelIndex idx = ....
QString s = Archives_dlg.getFileName(idx);

QModelIndex idx = ....
QString s = Archives_dlg.getFileName(idx);

To copy to clipboard, switch view to plain text mode 

[incapacitant]

same with '.' : 180 C:\Qt\test\sms\menu.cpp expected primary-expression before "const"

my previous call is with "->"

[incapacitant]

QString s = Archives_dlg->getFileName(idx);
180 C:\Qt\test\sms\menu.cpp base operand of `->' has non-pointer type `Archives'

getFileName is a public function of class Archives.

Just like another instance in the code where this time it is a public function of another class.
I cannot see any difference in the way I do it.

[jpn]

In C++, you access class members with operator "->" from a pointer, and with operator "." from an object.

You either:

Archives Archives_dlg(this);
Archives_dlg.blaa();

Archives Archives_dlg(this);
Archives_dlg.blaa();

To copy to clipboard, switch view to plain text mode 

OR

Archives* Archives_dlg = new Archives(this);
Archives_dlg->blaa();

Archives* Archives_dlg = new Archives(this);
Archives_dlg->blaa();

To copy to clipboard, switch view to plain text mode 

Notice the difference?

[incapacitant]

archiv.h

public:
  Archives( QWidget *parent = 0 );
  ~Archives();
  QString getFileName( const QModelIndex &);

public:
  Archives( QWidget *parent = 0 );
  ~Archives();
  QString getFileName( const QModelIndex &);

To copy to clipboard, switch view to plain text mode 

archiv.cpp

//****************************************************************
QString Archives::getFileName( const QModelIndex & idx )
{
  return model->data(idx.sibling(idx.row(), 0)).toString();
}

//****************************************************************
QString Archives::getFileName( const QModelIndex & idx )
{
  return model->data(idx.sibling(idx.row(), 0)).toString();
}

To copy to clipboard, switch view to plain text mode 

menu.cpp

//****************************************************************
void ApplicationWindow::archives()
{
  Archives Archives_dlg( this );
  if ( Archives_dlg.exec() )
  {
     QString s = Archives_dlg.getFileName(idx);
  }  
}

//****************************************************************
void ApplicationWindow::archives()
{
  Archives Archives_dlg( this );
  if ( Archives_dlg.exec() )
  {
     QString s = Archives_dlg.getFileName(idx);
  }  
}

To copy to clipboard, switch view to plain text mode 

compiler
QString s = Archives_dlg.getFileName(idx);
180 C:\Qt\test\sms\menu.cpp no matching function for call to `Archives::getFileName(QModelIndex*&)'

It's is parameter type wrong somewhere. But I have a similar piece of code that works.
I am lost.

[wysota]

Did you #include "archiv.h" in menu.cpp?

[incapacitant]

yes it is a new action in the same class that :

QStringList ret = Destinataires_dlg->getDestList();

QStringList ret = Destinataires_dlg->getDestList();

To copy to clipboard, switch view to plain text mode 

this compiles and works

QString s = Archives_dlg->getFileName(idx);

QString s = Archives_dlg->getFileName(idx);

To copy to clipboard, switch view to plain text mode 

this does not


just a new routine based on a click on the view

[incapacitant]

when i remove the qmodelindex parameter from all sides (.h.cpp) it compiles, so it comes from the qmodelindex which is not passed correctly and as i said i don't understand.

[jpn]

menu.cpp

//****************************************************************
void ApplicationWindow::archives()
{
  Archives Archives_dlg( this );
  if ( Archives_dlg.exec() )
  {
     QString s = Archives_dlg.getFileName(idx);
  }  
}

//****************************************************************
void ApplicationWindow::archives()
{
  Archives Archives_dlg( this );
  if ( Archives_dlg.exec() )
  {
     QString s = Archives_dlg.getFileName(idx);
  }  
}

To copy to clipboard, switch view to plain text mode 

Where do you declare that idx-variable?

Dunno if compilers even care about this, but you are also missing parameter name in archiv.h:
QString getFileName( const QModelIndex & idx);

[incapacitant]

I declare it in the connect :

connect( qArchiv, SIGNAL( clicked( const QModelIndex &) ), 
                this, SLOT( selectmsg( const QModelIndex &) ) );

connect( qArchiv, SIGNAL( clicked( const QModelIndex &) ), 
                this, SLOT( selectmsg( const QModelIndex &) ) );

To copy to clipboard, switch view to plain text mode 

archiv.h

#ifndef ARCHIVES_H
#define ARCHIVES_H
 
#include <qdialog.h>
 
#include <QtCore>
#include <QtGui>
 
class QAbstractItemModel;
class QTreeView;
class QModelIndex;
 
class Archives : public QDialog
{
    Q_OBJECT
 
public:
  Archives( QWidget *parent = 0 );
  ~Archives();
 
  QString getFileName( const QModelIndex & );
 
protected slots:
  void selectmsg( const QModelIndex & );
 
 
private:
  QAbstractItemModel *model;
  QTreeView *qArchiv;
  QPushButton *pbOk;
 
  void addArchiv( QString sDate, QString sDest, QString sMsg );
  void remplirArchiv();
 
};
 
#endif

#ifndef ARCHIVES_H
#define ARCHIVES_H

#include <qdialog.h>

#include <QtCore>
#include <QtGui>

class QAbstractItemModel;
class QTreeView;
class QModelIndex;

class Archives : public QDialog
{
    Q_OBJECT

public:
  Archives( QWidget *parent = 0 );
  ~Archives();
  
  QString getFileName( const QModelIndex & );
    
protected slots:
  void selectmsg( const QModelIndex & );


private:
  QAbstractItemModel *model;
  QTreeView *qArchiv;
  QPushButton *pbOk;

  void addArchiv( QString sDate, QString sDest, QString sMsg );
  void remplirArchiv();
  
};

#endif

To copy to clipboard, switch view to plain text mode 

//****************************************************************
void ApplicationWindow::archives()
{
  Archives Archives_dlg( this );
  if ( Archives_dlg.exec() )
  {
    QStringList ret = Destinataires_dlg->getDestList();
     QString qS = Archives_dlg.getFileName(const QModelIndex idx);  // 181
  }  
}

//****************************************************************
void ApplicationWindow::archives()
{
  Archives Archives_dlg( this );
  if ( Archives_dlg.exec() )
  {
    QStringList ret = Destinataires_dlg->getDestList();
     QString qS = Archives_dlg.getFileName(const QModelIndex idx);  // 181
  }  
}

To copy to clipboard, switch view to plain text mode 

only the second line which uses QModelIndex fails:
181 C:\Qt\test\sms\menu.cpp expected primary-expression before "const"

[incapacitant]

should i post a zip with all my files ?

[jpn]

So you want the return the selected item as a string?

archiv.h:

public:
   QString getFileName();

public:
   QString getFileName();

To copy to clipboard, switch view to plain text mode 

archiv.cpp:

QString Archives::getFileName()
{
   QModelIndex idx = qArchiv->selectionModel()->currentIndex();
   return model->data(idx.sibling(idx.row(), 0)).toString();
}

QString Archives::getFileName()
{
   QModelIndex idx = qArchiv->selectionModel()->currentIndex();
   return model->data(idx.sibling(idx.row(), 0)).toString();
}

To copy to clipboard, switch view to plain text mode 

menu.cpp:

void ApplicationWindow::archives()
{
   Archives Archives_dlg( this );
   if ( Archives_dlg.exec() )
   {
      QStringList ret = Destinataires_dlg->getDestList();
      QString qS = Archives_dlg.getFileName();  // 181
   } 
}

void ApplicationWindow::archives()
{
   Archives Archives_dlg( this );
   if ( Archives_dlg.exec() )
   {
      QStringList ret = Destinataires_dlg->getDestList();
      QString qS = Archives_dlg.getFileName();  // 181
   } 
}

To copy to clipboard, switch view to plain text mode 

[wysota]

QString qS = Archives_dlg.getFileName(const QModelIndex idx);

QString qS = Archives_dlg.getFileName(const QModelIndex idx);

To copy to clipboard, switch view to plain text mode 

You shouldn't use any type names in the call. It should like this:

QString qS = Archives_dlg.getFileName(idx);

QString qS = Archives_dlg.getFileName(idx);

To copy to clipboard, switch view to plain text mode 

[incapacitant]

QString qS = Archives_dlg.getFileName();

QString qS = Archives_dlg.getFileName();

To copy to clipboard, switch view to plain text mode 

compiler errors :
181 C:\Qt\test\sms\menu.cpp no matching function for call to `Archives::getFileName()'
note C:\Qt\test\sms\archiv.h:21 candidates are: QString Archives::getFileName(const QModelIndex&)
from .h declaration i suppose

I need this index it is the row that the user clicked on on the view. i cannot remove it everywhere.

[jpn]

Check carefully all the pieces of code I gave you (escpecially archiv.cpp).
It asks the current index from the view and returns it's data, there is no need to keep track of clicked items.. And you didn't store that clicked item anywhere anyway (and neither should you store model indexes, you are advised to use QPersistentModelIndex if you really need to)..

[incapacitant]

Thank you for your samples code, I did not see first about the IMPORTANT changes you had made. Now the slot is activated and I should be able to use it.