graphics view slow

[dognzhe]

this is funny reply.



find something in between. will not achieve the desired speed!

scroll by user is nonsense, have you play any game with scroll bar? unbelievable

[wysota]

scroll by user is nonsense, have you play any game with scroll bar? unbelievable

Who said anything about the user? I meant you as a programmer.

The fact that you don't understand what I said doesn't mean it is funny. If you design your application correctly you will achieve everything you want without problems. If you misdesign, you'll be running into problems on every step like it is happening now.

[dognzhe]

my logic is very simple, there is timer, when time out do all the drawing


any one can help??????

[wysota]

You're not listening. The problem is very unlikely to be drawing. If you have doubts about it, take a profiler and find the bottleneck.

[dognzhe]

#include "Tank.h"
 
Tank::Tank(QObject *parent,QGraphicsScene *scene)
  : QObject(parent), QGraphicsItem(0,scene)
{
  tankDirection=dRight;
  tankUp = new QPixmap(":/CannonBattle/Resources/tank up.jpg");
  tankDown= new QPixmap(":/CannonBattle/Resources/tank down.jpg");
  tankRight =new QPixmap(":/CannonBattle/Resources/tank right.jpg");
  tankLeft = new QPixmap(":/CannonBattle/Resources/tank left.jpg");
  if(tankUp->isNull() && tankDown->isNull() && tankRight->isNull()){
    emit error(QString("tank image load fails"));
  }
  /*
  
  label.setText("dongzhe adfasd fasdfsdafsadfasdfasd");
  //label.setMovie(movie);
 mo=this->scene()->addWidget(&label);
 mo->setPos(50,50);
 */
 
  this->setCacheMode(QGraphicsItem::DeviceCoordinateCache);
 
}
 
Tank::~Tank()
{
 
}
 
QPixmap* Tank::getImage() const{
 
  if(tankDirection==dRight){
    return tankRight;
  }else if(tankDirection== dLeft){
    return tankLeft;
  }else if(tankDirection== dUp){
    return tankUp;
  }else{
    return tankDown;
  }
 
}
 
QRectF Tank::boundingRect() const{
 
  //increase the boudingRect to get rid of marks
  return QRectF(getImage()->rect().x(),getImage()->rect().y(),getImage()->rect().width(),getImage()->rect().height()+2);
  //return getImage()->rect();
}
 
void Tank::paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget){
 
  painter->drawPixmap(QPoint(0,0),*getImage());
  //painter->drawImage(QPoint(0,0),QImage(":/CannonBattle/Resources/explose.gif"));
 
 
 
}
 
 
int Tank::type() const {
 
  return TANK_TYPE;
}
 
[/QTCLASS]
 
 
here is move tank
 
[QTCLASS]
void CannonField::tankMove(){
#if _DEBUG
  int a;
  int b;
  timeTemp.start();
  //timeTemp =QTime::currentTime();
 
#endif
 
  QPointF oldPoint(mainTank->pos());
  tankCurrentY = mainTank->pos().y();
  tankCurrentX= mainTank->pos().x();
  if(mainTank->tankDirection==mainTank->dUp){
    mainTank->setPos(tankCurrentX, tankCurrentY-tankSpeed);
  }
 
  if(mainTank->tankDirection==mainTank->dDown){
    mainTank->setPos(tankCurrentX, tankCurrentY+tankSpeed);
  }
 
  if(mainTank->tankDirection==mainTank->dLeft){
    mainTank->setPos(tankCurrentX-tankSpeed,tankCurrentY);
  }
 
  if(mainTank->tankDirection==mainTank->dRight){
    mainTank->setPos(tankCurrentX+tankSpeed,tankCurrentY);
  }
 
  tankCurrentY = mainTank->pos().y();
  tankCurrentX= mainTank->pos().x();
 
 
  if (tankCurrentX <0 || tankCurrentY<0 || tankCurrentX > (scene.width()-mainTank->boundingRect().width()) || tankCurrentY > (scene.height()-mainTank->boundingRect().height())) {
    mainTank->setPos(oldPoint);
  }
 
  QList<QGraphicsItem *> collisions = mainTank->collidingItems(Qt::IntersectsItemBoundingRect);
  if(!collisions.isEmpty()){
    QGraphicsItem *temp;
 
    QListIterator<QGraphicsItem *> it(collisions);
    while(it.hasNext()){
      temp= it.next();
      if(temp->type()==TARGET_TYPE){
        mainTank->setPos(oldPoint);
      }
    }
 
  }
 
 
  //graphicsView.centerOn(mainTank); 
  graphicsView.ensureVisible(mainTank,graphicsView.rect().width()/3,graphicsView.rect().height()/3);
  #if _DEBUG
  //for(int i=0;i<1000000;i++)
  //{i++;}
  //b=QTime::currentTime().msecsTo(timeTemp);
  a= timeTemp.elapsed();
  qDebug("%d\n",a);
#endif
}

#include "Tank.h"

Tank::Tank(QObject *parent,QGraphicsScene *scene)
  : QObject(parent), QGraphicsItem(0,scene)
{
  tankDirection=dRight;
  tankUp = new QPixmap(":/CannonBattle/Resources/tank up.jpg");
  tankDown= new QPixmap(":/CannonBattle/Resources/tank down.jpg");
  tankRight =new QPixmap(":/CannonBattle/Resources/tank right.jpg");
  tankLeft = new QPixmap(":/CannonBattle/Resources/tank left.jpg");
  if(tankUp->isNull() && tankDown->isNull() && tankRight->isNull()){
    emit error(QString("tank image load fails"));
  }
  /*
  
  label.setText("dongzhe adfasd fasdfsdafsadfasdfasd");
  //label.setMovie(movie);
 mo=this->scene()->addWidget(&label);
 mo->setPos(50,50);
 */

  this->setCacheMode(QGraphicsItem::DeviceCoordinateCache);

}

Tank::~Tank()
{

}

QPixmap* Tank::getImage() const{

  if(tankDirection==dRight){
    return tankRight;
  }else if(tankDirection== dLeft){
    return tankLeft;
  }else if(tankDirection== dUp){
    return tankUp;
  }else{
    return tankDown;
  }

}

QRectF Tank::boundingRect() const{
  
  //increase the boudingRect to get rid of marks
  return QRectF(getImage()->rect().x(),getImage()->rect().y(),getImage()->rect().width(),getImage()->rect().height()+2);
  //return getImage()->rect();
}

void Tank::paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget){

  painter->drawPixmap(QPoint(0,0),*getImage());
  //painter->drawImage(QPoint(0,0),QImage(":/CannonBattle/Resources/explose.gif"));
 
 

}


int Tank::type() const {

  return TANK_TYPE;
}

[/QTCLASS]


here is move tank

[QTCLASS]
void CannonField::tankMove(){
#if _DEBUG
  int a;
  int b;
  timeTemp.start();
  //timeTemp =QTime::currentTime();
  
#endif
  
  QPointF oldPoint(mainTank->pos());
  tankCurrentY = mainTank->pos().y();
  tankCurrentX= mainTank->pos().x();
  if(mainTank->tankDirection==mainTank->dUp){
    mainTank->setPos(tankCurrentX, tankCurrentY-tankSpeed);
  }

  if(mainTank->tankDirection==mainTank->dDown){
    mainTank->setPos(tankCurrentX, tankCurrentY+tankSpeed);
  }

  if(mainTank->tankDirection==mainTank->dLeft){
    mainTank->setPos(tankCurrentX-tankSpeed,tankCurrentY);
  }

  if(mainTank->tankDirection==mainTank->dRight){
    mainTank->setPos(tankCurrentX+tankSpeed,tankCurrentY);
  }

  tankCurrentY = mainTank->pos().y();
  tankCurrentX= mainTank->pos().x();


  if (tankCurrentX <0 || tankCurrentY<0 || tankCurrentX > (scene.width()-mainTank->boundingRect().width()) || tankCurrentY > (scene.height()-mainTank->boundingRect().height())) {
    mainTank->setPos(oldPoint);
  }

  QList<QGraphicsItem *> collisions = mainTank->collidingItems(Qt::IntersectsItemBoundingRect);
  if(!collisions.isEmpty()){
    QGraphicsItem *temp;
    
    QListIterator<QGraphicsItem *> it(collisions);
    while(it.hasNext()){
      temp= it.next();
      if(temp->type()==TARGET_TYPE){
        mainTank->setPos(oldPoint);
      }
    }

  }
  
  
  //graphicsView.centerOn(mainTank); 
  graphicsView.ensureVisible(mainTank,graphicsView.rect().width()/3,graphicsView.rect().height()/3);
  #if _DEBUG
  //for(int i=0;i<1000000;i++)
  //{i++;}
  //b=QTime::currentTime().msecsTo(timeTemp);
  a= timeTemp.elapsed();
  qDebug("%d\n",a);
#endif
}

To copy to clipboard, switch view to plain text mode 

I don;'t know what to do ...

[wysota]

Please take a profiler and find the bottle neck in your application. Now you're just shooting blind.

[dognzhe]

Please take a profiler and find the bottle neck in your application. Now you're just shooting blind.

where can i get profiler? is that free? can you give me a link????

[wysota]

http://www.google.com/search?q=profiling+applications

[dognzhe]

man, i can 't find the free one... i am using VS2005 with qt.

do you know any free one for downlaod?

[jano_alex_es]

I think you have one in Visual Studio 2005

[wysota]

man, i can 't find the free one... i am using VS2005 with qt.

Consider switching to a Free compiler then.