Multiple inheritance of QGraphicsView and QGraphicsItem

[cookie1909]

I do not use any stylesheets, everything is being painted. In order to have animation, I need to use either QGraphicsItem or QGraphicsProxyWidget for my button. I choose proxy widget so that connect() function can be called to do blinking effect when its timer expires.

I will try out putting all buttons in one view and hopefully the performance will be as good as you said

Thanks again!

[wysota]

I choose proxy widget so that connect() function can be called to do blinking effect when its timer expires.

It would be enough to inherit from both QGraphicsItem and QObject. Proxying through a widget just creates overhead.

[cookie1909]

I'm back with my improved code!

Like you suggested, I used one single view and have a table of QGraphicsItems within a scene. One blinking (every 0.5sec) button takes up about 10% CPU usage. Note that this is QtEmbedded I'm using, and we don't have a very powerful CPU, so 10% is acceptable.

Now I put my view into my real program that contains a window with tab widgets and buttons, all static widgets. One blinking button now takes 60% CPU, if I increase the blinking timer to 1sec interval, it drops down to 30%, and of course 0% when there's no blinking.

That tells me whenever the button blinks, more than just the button is being painted. I looked up the desc of QGraphicsItem::update()

As a side effect of the item being repainted, other items that overlap the area rect may also be repainted.

Can "other items that overlap" be the QGraphicsView that it belongs to, as well as the QWidget that the view belongs to? If so, it is redrawing a lot of unneccessary widgets.

Here's how I implement my paint function and blink slot:

QRectF LineButton::boundingRect() const                                                                                                    
{                                                                                                                                          
    return QRectF(mPicX, mPicY,  LINE_BUTTON_WIDTH, LINE_BUTTON_HEIGHT); 
}                                                                                                                                          
 
void LineButton::paint(                                                                                                                    
    QPainter *painter,                                                                                                                     
    const QStyleOptionGraphicsItem *option,                                                                                                
    QWidget *)                                                                                                                             
{                                                                                                                                          
    painter->setClipRect(option->exposedRect);                                                                                             
    painter->drawPixmap(mPicX, mPicY, *mPic);   
}          
 
void LineButton::blink()                                                                                                             
{                                                                                                                                          
    if (mPic == mPixmapBlack)                                                                                                              
        mPic = mPixmapYellow;                                                                                                              
    else                                                                                                                                   
        mPic = mPixmapBlack;                                                                                                               
    QGraphicsItem::update(boundingRect());                                                                                                 
}

QRectF LineButton::boundingRect() const                                                                                                    
{                                                                                                                                          
    return QRectF(mPicX, mPicY,  LINE_BUTTON_WIDTH, LINE_BUTTON_HEIGHT); 
}                                                                                                                                          
                                                                                                                                           
void LineButton::paint(                                                                                                                    
    QPainter *painter,                                                                                                                     
    const QStyleOptionGraphicsItem *option,                                                                                                
    QWidget *)                                                                                                                             
{                                                                                                                                          
    painter->setClipRect(option->exposedRect);                                                                                             
    painter->drawPixmap(mPicX, mPicY, *mPic);   
}          

void LineButton::blink()                                                                                                             
{                                                                                                                                          
    if (mPic == mPixmapBlack)                                                                                                              
        mPic = mPixmapYellow;                                                                                                              
    else                                                                                                                                   
        mPic = mPixmapBlack;                                                                                                               
    QGraphicsItem::update(boundingRect());                                                                                                 
}

To copy to clipboard, switch view to plain text mode 

[wysota]

Can "other items that overlap" be the QGraphicsView that it belongs to, as well as the QWidget that the view belongs to?

No. Items means graphics items in the view (or scene actually). Remember that if you use an OpenGL viewport for your graphics view then the whole viewport will be redrawn.

Here's how I implement my paint function and blink slot:

QRectF LineButton::boundingRect() const
{
    return QRectF(mPicX, mPicY,  LINE_BUTTON_WIDTH, LINE_BUTTON_HEIGHT);
}

QRectF LineButton::boundingRect() const
{
    return QRectF(mPicX, mPicY,  LINE_BUTTON_WIDTH, LINE_BUTTON_HEIGHT);
}

To copy to clipboard, switch view to plain text mode 

This is probably wrong. I'd guess it should say QRectF(0,0,LINE_BUTTON_WIDTH, LINE_BUTTON_HEIGHT) and then you should use QGraphicsItem::setPos() to position the button on the scene.

void LineButton::paint(
    QPainter *painter,                                                                                                                     
    const QStyleOptionGraphicsItem *option,                                                                                                
    QWidget *)                                                                                                                             
{                                                                                                                                          
    painter->setClipRect(option->exposedRect);                                                                                             
    painter->drawPixmap(mPicX, mPicY, *mPic);   
}

void LineButton::paint(
    QPainter *painter,                                                                                                                     
    const QStyleOptionGraphicsItem *option,                                                                                                
    QWidget *)                                                                                                                             
{                                                                                                                                          
    painter->setClipRect(option->exposedRect);                                                                                             
    painter->drawPixmap(mPicX, mPicY, *mPic);   
}

To copy to clipboard, switch view to plain text mode 

Don't clip the painter. It only slows you down. The architecture already sets up the clipper so you're doubling its work.

[cookie1909]

I read the Graphics View Framework docs, updated the coordinates like below, but it didn't make any difference in CPU usage I'm running out of ideas of what else to try

LineButton::LineButton(int x, int y)
{
    setPos(x, y);
    mPixmapBlack = new QPixmap("black.png");
    mPixmapYellow = new QPixmap("yellow.png");
    mPic = mPixmapBlack;
}
 
QRectF LineButton::boundingRect() const                                                                                                    
{                                                                                                                                          
    return QRectF(0, 0,  LINE_BUTTON_WIDTH, LINE_BUTTON_HEIGHT); 
}                                                                                                                                          
 
void LineButton::paint( 
    QPainter *painter, 
    const QStyleOptionGraphicsItem *option, 
    QWidget *) 
{                                                                                                                                          
    painter->drawPixmap(0, 0, *mPic); 
}          
 
void LineButton::blink()                                                                                                             
{                                                                                                                                          
    if (mPic == mPixmapBlack)  
        mPic = mPixmapYellow;     
   else 
        mPic = mPixmapBlack;        
   QGraphicsItem::update(boundingRect()); 
}

LineButton::LineButton(int x, int y)
{
    setPos(x, y);
    mPixmapBlack = new QPixmap("black.png");
    mPixmapYellow = new QPixmap("yellow.png");
    mPic = mPixmapBlack;
}

QRectF LineButton::boundingRect() const                                                                                                    
{                                                                                                                                          
    return QRectF(0, 0,  LINE_BUTTON_WIDTH, LINE_BUTTON_HEIGHT); 
}                                                                                                                                          
                                                                                                                                           
void LineButton::paint( 
    QPainter *painter, 
    const QStyleOptionGraphicsItem *option, 
    QWidget *) 
{                                                                                                                                          
    painter->drawPixmap(0, 0, *mPic); 
}          
 
void LineButton::blink()                                                                                                             
{                                                                                                                                          
    if (mPic == mPixmapBlack)  
        mPic = mPixmapYellow;     
   else 
        mPic = mPixmapBlack;        
   QGraphicsItem::update(boundingRect()); 
}

To copy to clipboard, switch view to plain text mode 

[cookie1909]

I finally found out what causes all of the repaintings!!!

I loaded this test program onto a device with a touch screen that is smaller than the Qt Window size. Everytime the button blinks, turned out Qt tries to repaint that button, as well as all other widgets of the window that got cut off by the LCD.

I fixed it so everything fits on the screen, one blinking button takes up 2% CPU, and all buttons blinking takes up 45% CPU, and am quite happy with that result.

Thanks so much again for all the help!