QThread vs QTcpServer feat. QTcpSocket

[wysota]

QEvent with the copy of QByteArray. i receives 16kBytes about 100 times per second, its too hard to copy all of these arrays.

Copy of a byte array is not the same as copy of the data it carries. QByteArray is an implicitly shared class thus there is only one copy of the data in question.

[ilyagoo]

i.e. using of QByteArray instead of queues of char* wouldn't decrease app's perfomance?

and would following code be correct to your mind?

void TClient::readyReadSlot()
{
    if ( !m_HeaderProcessed )
    {
        read( reinterpret_cast< char * >( &m_PackageHeader ), sizeof( m_PackageHeader ) );
        m_PackageHeaderProcessed = true;
    }
 
    int bytesToRead = bytesAvailable();
 
    if ( bytesToRead >= m_PackageHeader.MessageSize )
    {
        QByteArray message = read( m_PackageHeader.MessageSize );
        m_PackageHeaderProcessed = false;
 
        emit dataReceived( message );
    }
    else
        // read remaining data
        emit readyRead();
 
}

void TClient::readyReadSlot()
{
    if ( !m_HeaderProcessed )
    {
        read( reinterpret_cast< char * >( &m_PackageHeader ), sizeof( m_PackageHeader ) );
        m_PackageHeaderProcessed = true;
    }
    
    int bytesToRead = bytesAvailable();
    
    if ( bytesToRead >= m_PackageHeader.MessageSize )
    {
        QByteArray message = read( m_PackageHeader.MessageSize );
        m_PackageHeaderProcessed = false;
        
        emit dataReceived( message );
    }
    else
        // read remaining data
        emit readyRead();
    
}

To copy to clipboard, switch view to plain text mode 

and returning to:

TClientThread::run()
{
    TClient client;
    // little mistake))
    client.setSocketDescriptor( socketDescriptor );
    // use client's functions via signals
    connect( this, SIGNAL( someThreadSignals ), &client, SLOT( someThreadSlots() ) );
 
    exec();
}

TClientThread::run()
{
    TClient client;
    // little mistake))
    client.setSocketDescriptor( socketDescriptor );
    // use client's functions via signals
    connect( this, SIGNAL( someThreadSignals ), &client, SLOT( someThreadSlots() ) );
 
    exec();
}

To copy to clipboard, switch view to plain text mode 

i introduced signal TServer::clientDisconnected( TClient * ) because i need some information about disconnected client, for example, peerAddress & peerPort. this suggests me to use following code:

TClientThread::run()
{
    m_Client = new TClient;
    m_Client->setSocketDescriptor( socketDescriptor );
    // use client's functions via signals
    connect( this, SIGNAL( someThreadSignals ), m_Client, SLOT( someThreadSlots() ) );
 
    exec();
}

TClientThread::run()
{
    m_Client = new TClient;
    m_Client->setSocketDescriptor( socketDescriptor );
    // use client's functions via signals
    connect( this, SIGNAL( someThreadSignals ), m_Client, SLOT( someThreadSlots() ) );
 
    exec();
}

To copy to clipboard, switch view to plain text mode 

but how can i finish thread correct now?

[wysota]

i.e. using of QByteArray instead of queues of char* wouldn't decrease app's perfomance?

No. At least not in any noticable way.

and would following code be correct to your mind?

The first "if" block is very C-ish. IMO you should read the header into a byte array. The rest seems fine.

but how can i finish thread correct now?

I don't see your point...

By the way, are you sure you need threads at all? So far I see no reason to use them in your situation.

[ilyagoo]

returning to my phrase:

i introduced signal TServer::clientDisconnected( TClient * ) because i need some information about disconnected client, for example, peerAddress & peerPort.

i introduced signal TServer::clientDisconnected( TClient * ) because i need some information about disconnected client, for example, peerAddress & peerPort.

To copy to clipboard, switch view to plain text mode 

would it be correct to call client->peerPort() in the slot connected to aforesaid signal if this call and client are in different threads?