Advice needed - creating items

[tbscope]

I'm not sure what you mean or what the difference is you want to describe.

However, some solutions are personal taste. If it works for you and you feel happy with a solution, and it doesn't bother you, nobody will tell you it is wrong.

On the other hand, always keep your classes and their implementations as clean and simple as possible. If you can skip an extra object, do so. And keep in mind that if you want to make your program open source so other people can work on it too, you want to make the source as easy to read as possible and close to common standards.

[been_1990]

I mean:
This:

class Item{
       QGraphicsItem * mainItem;
       int eficiency;
       int power;
       QString abilities;
}

class Item{
       QGraphicsItem * mainItem;
       int eficiency;
       int power;
       QString abilities;
}

To copy to clipboard, switch view to plain text mode 

Versus this:

class Item : public QGraphicsItem{
       int eficiency;
       int power;
       QString abilities;
}

class Item : public QGraphicsItem{
       int eficiency;
       int power;
       QString abilities;
}

To copy to clipboard, switch view to plain text mode 

[Timoteo]

This is "inheritance vs composition". Depending on whom you ask and what your specific case is, it could go either way (rather both ways) as far as what is 'right'. I encourage you to pick up a book on the subject and/or google "inheritance vs composition" and decide for yourself.

[been_1990]

I'll just go with inheritance.

[wysota]

In the first case since the item doesn't inherit QGraphicsItem, you need some way to make the classes cooperate. For instance you need a way to map a QGraphicsItem to its Item counterpart as Graphics View operates in terms of QGraphicsItems.