Advice needed - creating items

[been_1990]

I mean:
This:

class Item{
       QGraphicsItem * mainItem;
       int eficiency;
       int power;
       QString abilities;
}

class Item{
       QGraphicsItem * mainItem;
       int eficiency;
       int power;
       QString abilities;
}

To copy to clipboard, switch view to plain text mode 

Versus this:

class Item : public QGraphicsItem{
       int eficiency;
       int power;
       QString abilities;
}

class Item : public QGraphicsItem{
       int eficiency;
       int power;
       QString abilities;
}

To copy to clipboard, switch view to plain text mode 

[Timoteo]

This is "inheritance vs composition". Depending on whom you ask and what your specific case is, it could go either way (rather both ways) as far as what is 'right'. I encourage you to pick up a book on the subject and/or google "inheritance vs composition" and decide for yourself.

[been_1990]

I'll just go with inheritance.

[wysota]

In the first case since the item doesn't inherit QGraphicsItem, you need some way to make the classes cooperate. For instance you need a way to map a QGraphicsItem to its Item counterpart as Graphics View operates in terms of QGraphicsItems.