QSslSocket vs QTcpSocket problem

[camol]

You don't need such while loops.

void Server::onReadyRead(){
  buffer.append(socket->readAll());
  while(buffer.size() >=4) {
    uint32 blockSize = buffer.at(0) << 24 | buffer.at(1) << 16 | buffer.at(2) << 8 | buffer.at(3); // or similar, e.g. qFromBigEndian
    if(buffer.size()>=4+blockSize){
        QByteArray data = buffer.mid(4,blockSize);
        buffer = buffer.mid(4+blockSize);
        processData(data);
    }
  }
}

void Server::onReadyRead(){
  buffer.append(socket->readAll());
  while(buffer.size() >=4) {
    uint32 blockSize = buffer.at(0) << 24 | buffer.at(1) << 16 | buffer.at(2) << 8 | buffer.at(3); // or similar, e.g. qFromBigEndian
    if(buffer.size()>=4+blockSize){
        QByteArray data = buffer.mid(4,blockSize);
        buffer = buffer.mid(4+blockSize);
        processData(data);
    }
  }
}

To copy to clipboard, switch view to plain text mode 

why you use while(buffer.size() >=4)? I mean for what "4" stands here for?

[wysota]

4 stands for sizeof(quint32).

Actually my code had a bug, it was missing an "else" statement. I just corrected it.

[camol]

void Server::onReadyRead()
{
    if(data == Size_of_Data)
    {
        QTextStream(stdout) << " Entering the slot = "<<a++ <<endl;
        buffer.append(clientSocket->readAll());
        while(buffer.size() >=4)
        {
            QTextStream(stdout) << " in while = "<<b++ <<endl;
            quint32 blockSize = buffer.at(0) << 24 | buffer.at(1) << 16 | buffer.at(2) << 8 | buffer.at(3); // or similar, e.g. qFromBigEndian
 
            QTextStream(stdout) << " before IF buffer = "<<buffer.size() <<endl;
            QTextStream(stdout) << " before IF blockSize = "<<sizeof(blockSize)<<endl;
 
            if(buffer.size()>=4+blockSize)
            {
                QTextStream(stdout) << " entering IF = "<<c++ <<endl;
                QByteArray data = buffer.mid(4,blockSize);
                buffer = buffer.mid(4+blockSize);
                QTextStream(stdout) << " in IF data = "<<data.size() <<endl;
                QTextStream(stdout) << " in IF buffer = "<<buffer.size() <<endl;
                //processData(data);
            }
            else
            {
                QTextStream(stdout) << " on output buffer.size = "<<buffer.size() <<endl;
                return;
            }
        }
    }
 
    else if(data == Exact_Data)
    {
        QTextStream(stdout) << "getting the right data"<<endl;
    }
}

void Server::onReadyRead()
{
    if(data == Size_of_Data)
    {
        QTextStream(stdout) << " Entering the slot = "<<a++ <<endl;
        buffer.append(clientSocket->readAll());
        while(buffer.size() >=4)
        {
            QTextStream(stdout) << " in while = "<<b++ <<endl;
            quint32 blockSize = buffer.at(0) << 24 | buffer.at(1) << 16 | buffer.at(2) << 8 | buffer.at(3); // or similar, e.g. qFromBigEndian

            QTextStream(stdout) << " before IF buffer = "<<buffer.size() <<endl;
            QTextStream(stdout) << " before IF blockSize = "<<sizeof(blockSize)<<endl;

            if(buffer.size()>=4+blockSize)
            {
                QTextStream(stdout) << " entering IF = "<<c++ <<endl;
                QByteArray data = buffer.mid(4,blockSize);
                buffer = buffer.mid(4+blockSize);
                QTextStream(stdout) << " in IF data = "<<data.size() <<endl;
                QTextStream(stdout) << " in IF buffer = "<<buffer.size() <<endl;
                //processData(data);
            }
            else
            {
                QTextStream(stdout) << " on output buffer.size = "<<buffer.size() <<endl;
                return;
            }
        }
    }

    else if(data == Exact_Data)
    {
        QTextStream(stdout) << "getting the right data"<<endl;
    }
}

To copy to clipboard, switch view to plain text mode 

I wrote sth like this, but i don't know exactle when I should pull out the right buffer.size out of the slot (to use it for expecting the incomimg file data)becouse, I've run a simple test and got:

Entering the slot = 0
 in while = 0
 before IF buffer = 4096
 before IF blockSize = 4
 entering IF = 0
 in IF data = 0
 in IF buffer = 4092
 in while = 1
 before IF buffer = 4092
 before IF blockSize = 4
 on output buffer.size = 4092
 Entering the slot = 1
 in while = 2
 before IF buffer = 8188
 before IF blockSize = 4
 on output buffer.size = 8188
 Entering the slot = 2
 in while = 3
 before IF buffer = 8848
 before IF blockSize = 4
 on output buffer.size = 8848

Entering the slot = 0
 in while = 0
 before IF buffer = 4096
 before IF blockSize = 4
 entering IF = 0
 in IF data = 0
 in IF buffer = 4092
 in while = 1
 before IF buffer = 4092
 before IF blockSize = 4
 on output buffer.size = 4092
 Entering the slot = 1
 in while = 2
 before IF buffer = 8188
 before IF blockSize = 4
 on output buffer.size = 8188
 Entering the slot = 2
 in while = 3
 before IF buffer = 8848
 before IF blockSize = 4
 on output buffer.size = 8848

To copy to clipboard, switch view to plain text mode 

[wysota]

Lines #3 and #18 suggest you have two variables called "data" where one shadows the other. What's the purpose of if in #3 anyway?

[camol]

But one is global the first one and the second one is local for the method, I've changed the first "data" to in_data but it doesn't has any influence. The in_data is an enum type, which I've created, becouse I thought slot onReadyRead always starts after signal readyRead so in_data informs that the incoming data is no longer the size of the file, but exactly the expected file.

EDIT:
When I'm sending a bigger file and I try get the size of it, the result of my test is a bit different:

Entering the slot = 0
 in while = 0
 before IF buffer = 4096
 before IF blockSize = 4
 entering IF = 0
 in IF data = 0
 in IF buffer = 4092
 in while = 1
 before IF buffer = 4092
 before IF blockSize = 4
 on output buffer.size = 4092
 Entering the slot = 1
 in while = 2
 before IF buffer = 8188
 before IF blockSize = 4
 on output buffer.size = 8188
 Entering the slot = 2
 in while = 3
 before IF buffer = 12284
 before IF blockSize = 4
 on output buffer.size = 12284
 Entering the slot = 3
 in while = 4
 before IF buffer = 16380
 before IF blockSize = 4
 on output buffer.size = 16380
 Entering the slot = 4
 in while = 5
 before IF buffer = 17688
 before IF blockSize = 4
 entering IF = 1
 in IF data = 17684
 in IF buffer = 0

Entering the slot = 0
 in while = 0
 before IF buffer = 4096
 before IF blockSize = 4
 entering IF = 0
 in IF data = 0
 in IF buffer = 4092
 in while = 1
 before IF buffer = 4092
 before IF blockSize = 4
 on output buffer.size = 4092
 Entering the slot = 1
 in while = 2
 before IF buffer = 8188
 before IF blockSize = 4
 on output buffer.size = 8188
 Entering the slot = 2
 in while = 3
 before IF buffer = 12284
 before IF blockSize = 4
 on output buffer.size = 12284
 Entering the slot = 3
 in while = 4
 before IF buffer = 16380
 before IF blockSize = 4
 on output buffer.size = 16380
 Entering the slot = 4
 in while = 5
 before IF buffer = 17688
 before IF blockSize = 4
 entering IF = 1
 in IF data = 17684
 in IF buffer = 0

To copy to clipboard, switch view to plain text mode 

Becouse my "test" ends in IF instruction now.

Another EDIT:
I've changed "4" in your code to "8" and now it stands for quint64 and everything looks like in the first example.

[wysota]

I still don't understand what the if is for. Anyway, sizeof(blockSize) will always return 4 (it's a 32 bit integer, after all) so I don't understand why you're checking it. Just to make sure - does the sending side encode the block size the same way the receiving size decodes it?

[camol]

I'm sending it like this:

void DServer::response_to_replication()
{
    QTextStream(stdout) << "wszedlem do RESPONSE_TO_REPLICATION" <<endl;
 
    /********************************************************************/
    /*SENDING LIST WITH STORED FILES TO SERVER WHICH ESTABLISHED CONNECTION*/
    /********************************************************************/
 
    blockSize = 0;
    QByteArray block;
    block.clear();
    QDataStream out(&block, QIODevice::WriteOnly);
    out.setVersion(QDataStream::Qt_4_6);
    serverfiles.clear();
    serverfiles = rfilelist();
 
 
    out << (quint64)0;
    out << (out,serverfiles);
 
    out.device()->seek(0);
    out << (quint64)(block.size() - sizeof(quint64));
}

void DServer::response_to_replication()
{
    QTextStream(stdout) << "wszedlem do RESPONSE_TO_REPLICATION" <<endl;

    /********************************************************************/
    /*SENDING LIST WITH STORED FILES TO SERVER WHICH ESTABLISHED CONNECTION*/
    /********************************************************************/

    blockSize = 0;
    QByteArray block;
    block.clear();
    QDataStream out(&block, QIODevice::WriteOnly);
    out.setVersion(QDataStream::Qt_4_6);
    serverfiles.clear();
    serverfiles = rfilelist();


    out << (quint64)0;
    out << (out,serverfiles);

    out.device()->seek(0);
    out << (quint64)(block.size() - sizeof(quint64));
}

To copy to clipboard, switch view to plain text mode 

the IF-thing: becouse date are coming to the client and when they are ready to read at client side the signal readyRead is emitted which is connected to one single slot called onReadyRead, so when I get the incoming data and interpretate them as the information about the size which was sent by server side of the connection. The signal readyRead will be still emited becouse now client will be receiving the exact data, and the onReadyRead slot will be triggered, so I want to prevent by using this IF-thing to prevent this slot from behaving as it is receiving size when it is already receving the exact expected data.

[wysota]

I'm sending it like this:

This won't work, obviously. The receiving end expects something completely different.

the IF-thing: becouse date are coming to the client and when they are ready to read at client side the signal readyRead is emitted which is connected to one single slot called onReadyRead, so when I get the incoming data and interpretate them as the information about the size which was sent by server side of the connection. The signal readyRead will be still emited becouse now client will be receiving the exact data, and the onReadyRead slot will be triggered, so I want to prevent by using this IF-thing to prevent this slot from behaving as it is receiving size when it is already receving the exact expected data.

Why do you want to prevent it? I think you don't understand the code I gave you. The slot is meant to fire each time new data arrives into the socket. Without any exceptions or special conditions. Otherwise you'll just lifelock your application.