Strange behavior of return statement

[amleto]

d_stranz has it.

[Raadush]

Ok, sorry for posting only that part of a code which is executed during one pass through MyMethod which is making problems. Whole MyMethod logic is:

void MyClass::MyMethod()
{
    verifyPIN(); //user promted to enter PIN here
    if(verification was successfull)                 
    {
        do some atcions
    } else if(verification was unsuccessfull)
    {
        if(PIN was locked)
        {
            message->setWindowTitle("Error");
            message->setText("PIN was locked");
            message->setInformativeText("Do you wand to unblock PIN?");
            message->setIcon(QMessageBox::Critical);
            message->setStandardButtons(QMessageBox::Yes | QMessageBox::No);
            ret = message->exec();
 
            if(ret == QMessageBox::Yes) unblockPIN();
            if(ret == QMessageBox::No)
            {
                 suggestAction->setEnabled(true);
                 solutions += "baz";
                 this->suggestSolutions();
            }
            return;
        }
 
        message->setWindowTitle("Title");
        message->setText("Wrong PIN");
        message->setIcon(QMessageBox::Critical);
        message->setStandardButtons(QMessageBox::Ok);
        message->exec();
        this->MyMethod();
    }
    treeClicked(navigator->currentItem());
}

void MyClass::MyMethod()
{
    verifyPIN(); //user promted to enter PIN here
    if(verification was successfull)                 
    {
        do some atcions
    } else if(verification was unsuccessfull)
    {
        if(PIN was locked)
        {
            message->setWindowTitle("Error");
            message->setText("PIN was locked");
            message->setInformativeText("Do you wand to unblock PIN?");
            message->setIcon(QMessageBox::Critical);
            message->setStandardButtons(QMessageBox::Yes | QMessageBox::No);
            ret = message->exec();
 
            if(ret == QMessageBox::Yes) unblockPIN();
            if(ret == QMessageBox::No)
            {
                 suggestAction->setEnabled(true);
                 solutions += "baz";
                 this->suggestSolutions();
            }
            return;
        }
 
        message->setWindowTitle("Title");
        message->setText("Wrong PIN");
        message->setIcon(QMessageBox::Critical);
        message->setStandardButtons(QMessageBox::Ok);
        message->exec();
        this->MyMethod();
    }
    treeClicked(navigator->currentItem());
}

To copy to clipboard, switch view to plain text mode 

[Lesiok]

Line 33 : MyMethod calls itself. This leads to a stack overflow.

[Raadush]

No, it does not. MyMethod calls itself only in case wrong PIN was entered and only limited times (3 times in most cases). After that, the pin is blocked and return statement is executed.

[wysota]

... and then you get a cascade of returns, which is what you observe.