Modification of a question

[R.ANGEL]

Hi there once again, thank you for the info from those two sites on QMaps and QLists. I understand the differences and concepts much better now after reading that info together with stuff on google. I didn't want to come back and post without attempting any solution to original posted question because that would mean I did not learn anything from the stuff I read. below is some code I wrote, consisting of my understanding of what the header and source file should look like, please check it and correct me if I misunderstood or am doing this incorrectly.

below is my header file:

#ifndef FILM_H
#define FILM_H
 
#include <QObject>
#include <QString>
#include <QMap>
 
class Film : public QObject
{
    Q_OBJECT
 
   public:
 
    Film (QString id, QString title, QString dir, QString length, QDate relDate);
    Film (QStringList propList);
    QString virtual toString (bool labelled, QString sepChar);
 
   private:  
 
    QString m_FilmId;
    QString m_Title;
    QString m_Director;
    QString m_FilmLength;
    QDate m_ReleaseDate;
 
};
 
//Managed collection of pointers
 
class FilmMap : public QMap<QString, Film*>
{
   public:
 
    QString toString() const;
    Film* findFilm (QString id);
    QString getId (QString title);
    void addFilm (Film* film);
    void removeFilm (QString filmId);
 
};
 
#endif

#ifndef FILM_H
#define FILM_H

#include <QObject>
#include <QString>
#include <QMap>

class Film : public QObject
{
    Q_OBJECT
  
   public:

    Film (QString id, QString title, QString dir, QString length, QDate relDate);
    Film (QStringList propList);
    QString virtual toString (bool labelled, QString sepChar);

   private:  

    QString m_FilmId;
    QString m_Title;
    QString m_Director;
    QString m_FilmLength;
    QDate m_ReleaseDate;

};

//Managed collection of pointers

class FilmMap : public QMap<QString, Film*>
{
   public:
    
    QString toString() const;
    Film* findFilm (QString id);
    QString getId (QString title);
    void addFilm (Film* film);
    void removeFilm (QString filmId);

};

#endif

To copy to clipboard, switch view to plain text mode 

Below is my implementation file:

#include <QMap>
#include <QMapIterator>
#include "film.h"
 
using namespace std;
 
QString FilmMap :: toString () const
{
  QString retval;
  QTextStream os(&retval);
  ConstIterator itr = constBegin();
  for (; itr != constEnd(); ++itr)
       os << '[' <<itr.key() << ']' << ":"
       << itr.value() -> toString() << endl;
  return retval;
}
 
Film* FilmMap :: findFilm (QString id)
{
 
}
 
QString FilmMap :: getId (QString title)
{
  return Id;
}
 
void FilmMap :: addFilm(Film* film)
{
   insert (film -> getId(), film);
}
 
void FilmMap :: removeFilm (QString filmId)
{
 
}

#include <QMap>
#include <QMapIterator>
#include "film.h"

using namespace std;

QString FilmMap :: toString () const
{
  QString retval;
  QTextStream os(&retval);
  ConstIterator itr = constBegin();
  for (; itr != constEnd(); ++itr)
       os << '[' <<itr.key() << ']' << ":"
       << itr.value() -> toString() << endl;
  return retval;
}

Film* FilmMap :: findFilm (QString id)
{

}

QString FilmMap :: getId (QString title)
{
  return Id;
}

void FilmMap :: addFilm(Film* film)
{
   insert (film -> getId(), film);
}

void FilmMap :: removeFilm (QString filmId)
{

}

To copy to clipboard, switch view to plain text mode 

I have coded what I understood of the question but I do not know how to implement the 'findFilm' and 'removeFilm' iterators, kindly advise me on this please and tell me if I have done the above correctly. I would also appreciate if you could tell me hoe I code the main function in order to test the functions in FilmMap. Thank you so much for all your assistance.

[wysota]

I didn't want to come back and post without attempting any solution to original posted question because that would mean I did not learn anything from the stuff I read.

Now that's a great attitude! Congratulations!

Before we get into lists and maps, please try to think whether you really need Film to inherit QObject and if not, whether you need the map to hold pointers to Film instances instead of just Film instances (i.e. QMap<int,Film> and not QMap<int,Film*>).

[R.ANGEL]

good morning

I need the map to hold pointers to film instances such as:

QMap<int, Film*>

in my opinion from reading the question.

[wysota]

Why do you need pointers?

[R.ANGEL]

I thought that since inheritance was occurring we would need to use pointers.

[wysota]

I thought that since inheritance was occurring we would need to use pointers.

Inheritance itself has nothing to do with this. Only if you inherit QObject you need to use pointers because QObject instances can't be copied. But your class does not require QObject legacy, thus my original question.

[R.ANGEL]

so I guess I have been attempting this solution the incorrect way by inheriting QObject and using pointers

[wysota]

It is not that it is incorrect, it's just more difficult and simply not required. I suggest you KISS.

[R.ANGEL]

I am unsure on how to proceed next in completing my solution though

[wysota]

Remove QObject legacy, change the map definition and implement functions for adding film instances to the map, removing them, etc.

[R.ANGEL]

ok thank you Sir, I will attempt that and repost my solution